From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ
Date: Fri, 24 Feb 2012 15:54:52 +0100 [thread overview]
Message-ID: <4F47A4BC.3020307@ti.com> (raw)
In-Reply-To: <4F479B31.7090508@gmail.com>
On 2/24/2012 3:14 PM, Rob Herring wrote:
> On 02/23/2012 04:46 PM, Cousson, Benoit wrote:
...
>> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
>> index bc2bd69..afef0f7 100644
>> --- a/drivers/gpio/gpio-omap.c
>> +++ b/drivers/gpio/gpio-omap.c
>> @@ -93,6 +93,11 @@ struct gpio_bank {
>> #define GPIO_BIT(bank, gpio) (1<< GPIO_INDEX(bank, gpio))
>> #define GPIO_MOD_CTRL_BIT BIT(0)
>>
>> +static int irq_to_gpio(struct gpio_bank *bank, unsigned int gpio_irq)
>> +{
>> + return gpio_irq - bank->irq_base + bank->chip.base;
>
> Ideally, you could do something like this when you have a domain setup:
>
> irq_get_irq_data(gpio_irq)->hw_irq + bank->chip.base
OK, good to know. I still plan to move the current irq_domain basic
support to the irqchip stuff you have done. I'll do that after 3.4.
> Also, with sparse irq you need to have a call to irq_alloc_desc.
irq_alloc_desc was already added as part of the DT migration patch.
It was not explicit in the changelog, but that patch is based on GPIO
cleanup + DT migration series.
> You can avoid that by setting NR_IRQS or machine .nr_irqs, but that needs to go
> away.
Based on a recommendation you did in the commit to fix GIC I did that in
the SPARSE_IRQ series I've just sent before that RFC patch:
+#ifdef CONFIG_SPARSE_IRQ
+#define NR_IRQS NR_IRQS_LEGACY
+#else
#define NR_IRQS OMAP_GPMC_IRQ_END
+#endif
> Otherwise, it certainly is a step in the right direction.
Yeah, there is still a long way to clean all the old nasty IRQ stuff in
OMAP :-)
Thanks,
Benoit
prev parent reply other threads:[~2012-02-24 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:46 [RFC PATCH] gpio/omap: Fix IRQ handling for SPARSE_IRQ Cousson, Benoit
2012-02-23 23:08 ` Tony Lindgren
2012-02-24 10:11 ` Cousson, Benoit
2012-02-24 10:37 ` DebBarma, Tarun Kanti
2012-02-24 13:24 ` DebBarma, Tarun Kanti
2012-02-24 13:32 ` Cousson, Benoit
2012-02-24 13:53 ` DebBarma, Tarun Kanti
2012-02-24 13:56 ` Cousson, Benoit
2012-02-24 15:09 ` DebBarma, Tarun Kanti
2012-02-24 15:12 ` Cousson, Benoit
2012-02-24 14:14 ` Rob Herring
2012-02-24 14:54 ` Cousson, Benoit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47A4BC.3020307@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox