From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
Date: Thu, 08 Mar 2012 13:09:04 -0700 [thread overview]
Message-ID: <4F5911E0.6060802@wwwdotorg.org> (raw)
In-Reply-To: <1331218291-16119-10-git-send-email-thierry.reding@avionic-design.de>
On 03/08/2012 07:51 AM, Thierry Reding wrote:
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design•de>
Patch description?
> diff --git a/arch/arm/mach-tegra/board-harmony-pcie.c b/arch/arm/mach-tegra/board-harmony-pcie.c
...
> -static int __init harmony_pcie_init(void)
> +static int tegra_pcie_init(struct platform_device *pdev)
That name should probably still be called harmony_something() since it's
still board-specific.
I wonder how having a per-board callback will integrate with device
tree. I guess I'll find out when I review patch 11:-)
> diff --git a/arch/arm/mach-tegra/board-trimslice.c b/arch/arm/mach-tegra/board-trimslice.c
> +static int __init trimslice_pci_init(void)
> {
> if (!machine_is_trimslice())
> return 0;
You can remove that test now.
> diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
> +#define TEGRA_PCIE_MAX_PORTS 2
> +
> +struct tegra_pcie_pdata {
> + int (*init)(struct platform_device *pdev);
> + int (*exit)(struct platform_device *pdev);
> + bool enable_ports[TEGRA_PCIE_MAX_PORTS];
> +};
That's a somewhat odd place to put the header; a dedicated
mach-tegra/include/mach/tegra_pcie_pdata.h or
include/linux/platform_data/tegra_pcie.h might make more sense.
Aside from those pretty minor issues, this all looks great. Thanks for
fixing our driver!
next prev parent reply other threads:[~2012-03-08 20:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:51 [PATCH 00/11] ARM: tegra: Add PCIe device tree support Thierry Reding
2012-03-08 14:51 ` [PATCH 01/11] drivercore: Add driver probe deferral mechanism Thierry Reding
2012-03-19 23:12 ` Sylwester Nawrocki
2012-03-20 14:21 ` Grant Likely
2012-03-08 14:51 ` [PATCH 02/11] regulator: Support driver probe deferral Thierry Reding
2012-03-08 14:51 ` [PATCH 03/11] regulator: fixed: " Thierry Reding
2012-03-11 12:58 ` Mark Brown
2012-03-08 14:51 ` [PATCH 04/11] regulator: tps6586x: fix typo in debug message Thierry Reding
2012-03-08 19:08 ` Mark Brown
2012-03-08 14:51 ` [PATCH 05/11] tps6586x: Add device-tree support Thierry Reding
2012-03-08 15:06 ` Mark Brown
2012-03-08 15:15 ` Thierry Reding
2012-03-08 15:17 ` Mark Brown
2012-03-08 15:45 ` Thierry Reding
2012-03-09 5:15 ` Grant Likely
2012-03-09 7:53 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 06/11] PCI: Keep pci_fixup_irqs() around after init Thierry Reding
2012-03-08 17:27 ` Bjorn Helgaas
2012-03-08 18:37 ` Thierry Reding
2012-03-08 18:41 ` Bjorn Helgaas
2012-03-08 14:51 ` [PATCH 07/11] ARM: pci: Keep pci_common_init() " Thierry Reding
2012-03-08 14:51 ` [PATCH 08/11] ARM: tegra: Move tegra_pcie_xclk_clamp() to PMC Thierry Reding
2012-03-08 19:50 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver Thierry Reding
2012-03-08 20:09 ` Stephen Warren [this message]
2012-03-09 6:37 ` Thierry Reding
2012-03-09 16:42 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 10/11] ARM: tegra: pcie: Add MSI support Thierry Reding
2012-03-08 21:14 ` Stephen Warren
2012-03-09 6:50 ` Thierry Reding
2012-03-09 16:45 ` Stephen Warren
2012-03-12 8:00 ` Thierry Reding
2012-03-12 16:57 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 11/11] ARM: tegra: pcie: Add device tree support Thierry Reding
2012-03-08 21:31 ` Stephen Warren
2012-03-09 6:31 ` Thierry Reding
2012-03-09 16:47 ` Stephen Warren
2012-03-12 12:06 ` Mark Brown
2012-03-12 14:17 ` Thierry Reding
2012-03-12 14:23 ` Mark Brown
2012-03-12 14:28 ` Thierry Reding
2012-03-12 14:32 ` Mark Brown
2012-03-08 15:22 ` [PATCH 00/11] ARM: tegra: Add PCIe " Rob Herring
2012-03-08 15:43 ` Thierry Reding
2012-03-09 4:54 ` Grant Likely
2012-03-18 17:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5911E0.6060802@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox