From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 11/11] ARM: tegra: pcie: Add device tree support
Date: Fri, 09 Mar 2012 09:47:11 -0700 [thread overview]
Message-ID: <4F5A340F.6080303@wwwdotorg.org> (raw)
In-Reply-To: <20120309063115.GA25208@avionic-0098.mockup.avionic-design.de>
On 03/08/2012 11:31 PM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 03/08/2012 07:51 AM, Thierry Reding wrote:
>>> This commit adds support for instantiating the Tegra PCIe controller
>>> from a device tree.
>>>
>>> Signed-off-by: Thierry Reding <thierry.reding@avionic-design•de>
>>
>>> diff --git a/Documentation/devicetree/bindings/pci/tegra-pcie.txt b/Documentation/devicetree/bindings/pci/tegra-pcie.txt
>>
>>> +NVIDIA Tegra PCIe controller
>>> +
>>> +Required properties:
>>> +- compatible: "nvidia,tegra20-pcie"
>>> +- reg: physical base address and length of the controller's registers
>>> +- interrupts: the interrupt outputs of the controller
>>> +
>>> +Optional properties:
>>> +- pex-clk-supply: supply voltage for internal reference clock
>>> +- vdd-supply: power supply for controller (1.05V)
>>
>> Mark, Liam,
>>
>> Should those *-supply properties really be optional? I got the
>> impression talking to Mark in a different thread that all regulators
>> should exist, although their implementation may be via a fixed
>> regulator, with no GPIO, as determined by the board design.
>
> If I read the TrimSlice code correctly, there is no regulator setup required
> to make PCIe work there presumably because they hardwire the proper voltages.
Yes. I believe that's exactly what the fixed regulator is for.
> On the other hand, maybe a better solution in this case would be to use the
> dummy regulator in those cases.
Mark indicated dummy regulators weren't the preferred mechanism:
http://lkml.org/lkml/2012/2/25/30
next prev parent reply other threads:[~2012-03-09 16:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:51 [PATCH 00/11] ARM: tegra: Add PCIe device tree support Thierry Reding
2012-03-08 14:51 ` [PATCH 01/11] drivercore: Add driver probe deferral mechanism Thierry Reding
2012-03-19 23:12 ` Sylwester Nawrocki
2012-03-20 14:21 ` Grant Likely
2012-03-08 14:51 ` [PATCH 02/11] regulator: Support driver probe deferral Thierry Reding
2012-03-08 14:51 ` [PATCH 03/11] regulator: fixed: " Thierry Reding
2012-03-11 12:58 ` Mark Brown
2012-03-08 14:51 ` [PATCH 04/11] regulator: tps6586x: fix typo in debug message Thierry Reding
2012-03-08 19:08 ` Mark Brown
2012-03-08 14:51 ` [PATCH 05/11] tps6586x: Add device-tree support Thierry Reding
2012-03-08 15:06 ` Mark Brown
2012-03-08 15:15 ` Thierry Reding
2012-03-08 15:17 ` Mark Brown
2012-03-08 15:45 ` Thierry Reding
2012-03-09 5:15 ` Grant Likely
2012-03-09 7:53 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 06/11] PCI: Keep pci_fixup_irqs() around after init Thierry Reding
2012-03-08 17:27 ` Bjorn Helgaas
2012-03-08 18:37 ` Thierry Reding
2012-03-08 18:41 ` Bjorn Helgaas
2012-03-08 14:51 ` [PATCH 07/11] ARM: pci: Keep pci_common_init() " Thierry Reding
2012-03-08 14:51 ` [PATCH 08/11] ARM: tegra: Move tegra_pcie_xclk_clamp() to PMC Thierry Reding
2012-03-08 19:50 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver Thierry Reding
2012-03-08 20:09 ` Stephen Warren
2012-03-09 6:37 ` Thierry Reding
2012-03-09 16:42 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 10/11] ARM: tegra: pcie: Add MSI support Thierry Reding
2012-03-08 21:14 ` Stephen Warren
2012-03-09 6:50 ` Thierry Reding
2012-03-09 16:45 ` Stephen Warren
2012-03-12 8:00 ` Thierry Reding
2012-03-12 16:57 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 11/11] ARM: tegra: pcie: Add device tree support Thierry Reding
2012-03-08 21:31 ` Stephen Warren
2012-03-09 6:31 ` Thierry Reding
2012-03-09 16:47 ` Stephen Warren [this message]
2012-03-12 12:06 ` Mark Brown
2012-03-12 14:17 ` Thierry Reding
2012-03-12 14:23 ` Mark Brown
2012-03-12 14:28 ` Thierry Reding
2012-03-12 14:32 ` Mark Brown
2012-03-08 15:22 ` [PATCH 00/11] ARM: tegra: Add PCIe " Rob Herring
2012-03-08 15:43 ` Thierry Reding
2012-03-09 4:54 ` Grant Likely
2012-03-18 17:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A340F.6080303@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox