From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] clkdev: Implement managed clk_get()
Date: Sun, 01 Apr 2012 08:26:10 -0700 [thread overview]
Message-ID: <4F787392.5040308@codeaurora.org> (raw)
In-Reply-To: <1333279960-8497-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On 4/1/2012 4:32 AM, Mark Brown wrote:
> Allow clk API users to simplify their cleanup paths by providing a
> managed version of clk_get().
I was thinking the same thing last week.
>
> Due to the lack of a standard struct clk to look up the device from a
> managed clk_put() is not provided, it would be very unusual to use this
> function so it's not a big loss.
>
> Signed-off-by: Mark Brown <broonie@opensource•wolfsonmicro.com>
> ---
> Documentation/driver-model/devres.txt | 3 +++
> drivers/clk/clkdev.c | 25 +++++++++++++++++++++++++
> include/linux/clk.h | 20 ++++++++++++++++++++
> 3 files changed, 48 insertions(+), 0 deletions(-)
>
But why is this part of clkdev.c? devm_clk_get() should work regardless
of the implementation of clk_get() so can we put it into some other file
that is compiled if HAVE_CLK=y so everyone benefits from this and not
just users who select CLKDEV_LOOKUP?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-04-01 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 11:32 [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section Mark Brown
2012-04-01 11:32 ` [PATCH 2/2] clkdev: Implement managed clk_get() Mark Brown
2012-04-01 15:26 ` Stephen Boyd [this message]
2012-04-01 15:34 ` Mark Brown
2012-04-02 16:48 ` Stephen Boyd
2012-04-02 16:52 ` Russell King - ARM Linux
2012-04-02 17:04 ` Stephen Boyd
2012-04-02 17:08 ` Russell King - ARM Linux
2012-04-02 17:16 ` Stephen Boyd
2012-04-02 17:21 ` Russell King - ARM Linux
2012-04-02 17:34 ` Stephen Boyd
2012-04-02 18:02 ` Russell King - ARM Linux
2012-04-02 17:16 ` Mark Brown
2012-04-02 17:30 ` Turquette, Mike
2012-04-02 17:04 ` Russell King - ARM Linux
2012-04-02 17:34 ` Mark Brown
2012-04-02 18:05 ` Russell King - ARM Linux
2012-04-01 13:02 ` [PATCH 1/2] clk: Fix comment for end of CONFIG_COMMON_CLK section Russell King - ARM Linux
2012-04-01 14:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F787392.5040308@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox