From: lee.jones@linaro•org (Lee Jones)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6/7] MMC: mmci: Enable Device Tree support for ux500 variants
Date: Fri, 13 Apr 2012 16:16:28 +0100 [thread overview]
Message-ID: <4F88434C.9010709@linaro.org> (raw)
In-Reply-To: <1334329500.27644.18.camel@hornet>
On 13/04/12 16:05, Pawel Moll wrote:
> On Fri, 2012-04-13 at 15:54 +0100, Lee Jones wrote:
>> On 13/04/12 15:51, Arnd Bergmann wrote:
>>> On Friday 13 April 2012, Pawel Moll wrote:
>>>> On Fri, 2012-04-13 at 15:05 +0100, Lee Jones wrote:
>>>>> + of_property_read_u32(np, "wp-gpios",&pdata->gpio_wp);
>>>>> + if (!pdata->gpio_wp)
>>>>> + pdata->gpio_wp = -1;
>>>>> +
>>>>> + of_property_read_u32(np, "cd-gpios",&pdata->gpio_cd);
>>>>> + if (!pdata->gpio_cd)
>>>>> + pdata->gpio_cd = -1;
>>>>
>>>> I think you should use of_gpio_named_count(np, "XX-gpios") here rather
>>>> then of_property_read() - there's more to GPIOs than just a number...
>
> Of course I meant of_get_named_gpio(np, "XX-gpios", 0) not
> _named_count ;-)
>
>>> Hmm, that part was done right in the git tree, I guess something
>>> went wrong when sending out the series.
>>
>> Different patch series.
>>
>> The GPIO bindings aren't in yet. Once this one is accepted, I'll fire
>> off the second patch-set.
>
> Em, I'm not sure I'm following... Why not use the proper API
> immediately?
>
> Generally, except for that, looks good to me.
Because in it's current state, gpio-nomadik doesn't know how to decode
any provided flags and phandles don't work yet, hence the IRQ request
really is just a number in this case. In a latter patch-set I provide
the GPIO driver with said bindings and swap the simple integer format
for one which is more in keeping with the DT format e.g. <32> becomes
<&gpio1 1 0x4> for instance.
This patch does function perfectly well the way it is and provides no
breakage. I'm aiming for both patch-sets to be sucked into the v3.5
merge window in any case, so all functionality will be provided at -rc1.
Only the bleeding edge, hardcore, kernel developers who use the
gpio-nomadik driver (so, just me and Linus Walleij then :D ) will ever
use this code as-is.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-04-13 15:16 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 14:05 [PATCH 0/7 v2] Next round of DT enablement for ux500/Snowball Lee Jones
2012-04-13 14:05 ` [PATCH 1/7] ARM: ux500: Rename the DT compatible entry for i2c devices on Snowball Lee Jones
2012-04-16 8:34 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 2/7] ARM: ux500: Shorten Snowball's DT compatible gpio entry Lee Jones
2012-04-16 8:36 ` Linus Walleij
2012-04-16 9:00 ` Lee Jones
2012-04-13 14:05 ` [PATCH 3/7] drivers/gpio: gpio-nomadik: Apply Device Tree bindings Lee Jones
2012-04-16 8:40 ` Linus Walleij
2012-05-17 21:33 ` Grant Likely
2012-05-18 7:37 ` Lee Jones
2012-04-13 14:05 ` [PATCH 4/7] drivers/gpio: gpio-nomadik: Provide documentation for " Lee Jones
2012-04-13 14:59 ` Lee Jones
2012-04-16 8:43 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 5/7] ARM: ux500: Rename gpio_keys in the Device Tree file Lee Jones
2012-04-13 14:05 ` [PATCH 6/7] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-04-13 14:42 ` Pawel Moll
2012-04-13 14:51 ` Arnd Bergmann
2012-04-13 14:54 ` Lee Jones
2012-04-13 15:05 ` Pawel Moll
2012-04-13 15:16 ` Lee Jones [this message]
2012-04-13 15:27 ` Pawel Moll
2012-04-16 8:48 ` Linus Walleij
2012-04-16 9:06 ` Lee Jones
2012-04-16 9:18 ` Linus Walleij
2012-04-16 9:25 ` [PATCH 6.1/7] ARM: ux500: Enable Device Tree support mmci for Snowball Lee Jones
2012-04-16 9:26 ` [PATCH 6.2/7] MMC: mmci: Enable Device Tree support for ux500 Lee Jones
2012-04-25 18:57 ` Russell King - ARM Linux
2012-04-30 8:25 ` Lee Jones
2012-05-03 15:03 ` Lee Jones
2012-05-03 15:12 ` Russell King - ARM Linux
2012-05-03 15:18 ` Lee Jones
2012-05-03 15:30 ` Lee Jones
2012-05-03 16:30 ` Russell King - ARM Linux
2012-05-03 16:38 ` Lee Jones
2012-05-03 16:45 ` Russell King - ARM Linux
2012-05-03 16:59 ` Lee Jones
2012-05-03 17:13 ` Mark Brown
2012-05-03 21:21 ` Lee Jones
2012-05-03 17:09 ` Chris Ball
2012-05-04 13:18 ` Lee Jones
2012-05-04 13:26 ` Chris Ball
2012-05-04 13:39 ` Lee Jones
2012-05-07 22:00 ` Paul Gortmaker
2012-05-08 11:19 ` Lee Jones
2012-05-08 12:18 ` Chris Ball
2012-05-08 12:59 ` Lee Jones
2012-05-08 14:38 ` Chris Ball
2012-05-08 23:58 ` Paul Gortmaker
2012-05-09 0:29 ` Chris Ball
2012-05-09 0:52 ` Paul Gortmaker
2012-06-04 10:14 ` Russell King - ARM Linux
2012-06-05 10:47 ` Lee Jones
2012-06-05 10:52 ` Russell King - ARM Linux
2012-06-05 12:59 ` Linus Walleij
2012-06-06 8:09 ` Lee Jones
2012-06-11 10:03 ` Lee Jones
2012-06-11 10:34 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 7/7] MMC: mmci: Add required documentation for Device Tree bindings Lee Jones
2012-04-18 14:31 ` Pawel Moll
2012-04-18 15:01 ` Pawel Moll
2012-04-18 15:12 ` Lee Jones
2012-04-18 15:20 ` Chris Ball
2012-04-18 15:25 ` Lee Jones
2012-04-18 15:20 ` [PATCH 7/7 v2] " Lee Jones
2012-05-17 21:23 ` [PATCH 7/7] " Grant Likely
2012-04-13 14:21 ` [PATCH 0/7 v2] Next round of DT enablement for ux500/Snowball Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2012-04-05 10:25 [PATCH 1/7] ARM: ux500: New DT:ed snowball_platform_devs for one-by-one device enablement Lee Jones
2012-04-05 10:25 ` [PATCH 6/7] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-04-05 9:55 [0/7] Next round of DT enablement for ux500/Snowball Lee Jones
2012-04-05 9:55 ` [PATCH 6/7] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-04-05 12:36 ` Russell King - ARM Linux
2012-04-05 13:45 ` Lee Jones
2012-04-06 4:14 ` Grant Likely
2012-04-09 14:27 ` Arnd Bergmann
2012-04-09 14:41 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F88434C.9010709@linaro.org \
--to=lee.jones@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox