From: cjb@laptop•org (Chris Ball)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 6.2/7] MMC: mmci: Enable Device Tree support for ux500
Date: Tue, 08 May 2012 20:29:06 -0400 [thread overview]
Message-ID: <87sjfap57x.fsf@laptop.org> (raw)
In-Reply-To: <CAP=VYLoz0o7qh9TNgWPatAsSjtoKoyaBUW7L+3q1w0PsLkOMOQ@mail.gmail.com> (Paul Gortmaker's message of "Tue, 8 May 2012 19:58:49 -0400")
Hi Paul,
On Tue, May 08 2012, Paul Gortmaker wrote:
> On Tue, May 8, 2012 at 8:59 AM, Lee Jones <lee.jones@linaro•org> wrote:
>> Here you go Chris.
>>
>> From: Lee Jones <lee.jones@linaro•org>
>> Date: Tue, 8 May 2012 13:40:02 +0100
>> Subject: [PATCH] MMC: mmci: Fix compiler error when CONFIG_OF is not set
>>
>> error: implicit declaration of function 'mmci_dt_populate_generic_pdata'
>>
>> This is due to the '#if CONFIG_OF' guards placed around
>> mmci_dt_populate_generic_pdata(), but not around the call to it. We
>> repair this by inserting a stub which elegantly returns when CONFIG_OF
>> is not set.
>>
>> Signed-off-by: Lee Jones <lee.jones@linaro•org>
>
> Please if possible, do not neglect to add the Reported-by: line when
> appropriate. I've been at this long enough that it really won't change
> my life any if it is there or not there, but for someone new to linux, it
> might make the difference between an "I'm glad I reported that" vs.
> a "Screw them, I'm not reporting anything else in the future."
Agreed -- I added a Reported-by line when I applied the patch:
http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=c0a120a4bc68f5dc5f5238e76013cc18bac0ffed
Thanks,
- Chris.
--
Chris Ball <cjb@laptop•org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-05-09 0:29 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 14:05 [PATCH 0/7 v2] Next round of DT enablement for ux500/Snowball Lee Jones
2012-04-13 14:05 ` [PATCH 1/7] ARM: ux500: Rename the DT compatible entry for i2c devices on Snowball Lee Jones
2012-04-16 8:34 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 2/7] ARM: ux500: Shorten Snowball's DT compatible gpio entry Lee Jones
2012-04-16 8:36 ` Linus Walleij
2012-04-16 9:00 ` Lee Jones
2012-04-13 14:05 ` [PATCH 3/7] drivers/gpio: gpio-nomadik: Apply Device Tree bindings Lee Jones
2012-04-16 8:40 ` Linus Walleij
2012-05-17 21:33 ` Grant Likely
2012-05-18 7:37 ` Lee Jones
2012-04-13 14:05 ` [PATCH 4/7] drivers/gpio: gpio-nomadik: Provide documentation for " Lee Jones
2012-04-13 14:59 ` Lee Jones
2012-04-16 8:43 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 5/7] ARM: ux500: Rename gpio_keys in the Device Tree file Lee Jones
2012-04-13 14:05 ` [PATCH 6/7] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-04-13 14:42 ` Pawel Moll
2012-04-13 14:51 ` Arnd Bergmann
2012-04-13 14:54 ` Lee Jones
2012-04-13 15:05 ` Pawel Moll
2012-04-13 15:16 ` Lee Jones
2012-04-13 15:27 ` Pawel Moll
2012-04-16 8:48 ` Linus Walleij
2012-04-16 9:06 ` Lee Jones
2012-04-16 9:18 ` Linus Walleij
2012-04-16 9:25 ` [PATCH 6.1/7] ARM: ux500: Enable Device Tree support mmci for Snowball Lee Jones
2012-04-16 9:26 ` [PATCH 6.2/7] MMC: mmci: Enable Device Tree support for ux500 Lee Jones
2012-04-25 18:57 ` Russell King - ARM Linux
2012-04-30 8:25 ` Lee Jones
2012-05-03 15:03 ` Lee Jones
2012-05-03 15:12 ` Russell King - ARM Linux
2012-05-03 15:18 ` Lee Jones
2012-05-03 15:30 ` Lee Jones
2012-05-03 16:30 ` Russell King - ARM Linux
2012-05-03 16:38 ` Lee Jones
2012-05-03 16:45 ` Russell King - ARM Linux
2012-05-03 16:59 ` Lee Jones
2012-05-03 17:13 ` Mark Brown
2012-05-03 21:21 ` Lee Jones
2012-05-03 17:09 ` Chris Ball
2012-05-04 13:18 ` Lee Jones
2012-05-04 13:26 ` Chris Ball
2012-05-04 13:39 ` Lee Jones
2012-05-07 22:00 ` Paul Gortmaker
2012-05-08 11:19 ` Lee Jones
2012-05-08 12:18 ` Chris Ball
2012-05-08 12:59 ` Lee Jones
2012-05-08 14:38 ` Chris Ball
2012-05-08 23:58 ` Paul Gortmaker
2012-05-09 0:29 ` Chris Ball [this message]
2012-05-09 0:52 ` Paul Gortmaker
2012-06-04 10:14 ` Russell King - ARM Linux
2012-06-05 10:47 ` Lee Jones
2012-06-05 10:52 ` Russell King - ARM Linux
2012-06-05 12:59 ` Linus Walleij
2012-06-06 8:09 ` Lee Jones
2012-06-11 10:03 ` Lee Jones
2012-06-11 10:34 ` Linus Walleij
2012-04-13 14:05 ` [PATCH 7/7] MMC: mmci: Add required documentation for Device Tree bindings Lee Jones
2012-04-18 14:31 ` Pawel Moll
2012-04-18 15:01 ` Pawel Moll
2012-04-18 15:12 ` Lee Jones
2012-04-18 15:20 ` Chris Ball
2012-04-18 15:25 ` Lee Jones
2012-04-18 15:20 ` [PATCH 7/7 v2] " Lee Jones
2012-05-17 21:23 ` [PATCH 7/7] " Grant Likely
2012-04-13 14:21 ` [PATCH 0/7 v2] Next round of DT enablement for ux500/Snowball Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjfap57x.fsf@laptop.org \
--to=cjb@laptop$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox