From: stigge@antcom•de (Roland Stigge)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC] pl08x: don't use dma_slave_config direction argument
Date: Wed, 16 May 2012 14:24:02 +0200 [thread overview]
Message-ID: <4FB39C62.3030305@antcom.de> (raw)
In-Reply-To: <20120516110451.GA9571@n2100.arm.linux.org.uk>
Hi,
On 05/16/2012 01:04 PM, Russell King - ARM Linux wrote:
> This series removes the dependence on the dma_slave_config direction
> argument for the PL08x DMA engine driver, and in doing so, we end up
> with less code in the driver.
>
> We now compute the cctl values for both directions, and continue to
> select the appropriate one at prepare time. If this is found to be
> invalid, the prepare function will return NULL.
>
> However, we still use the direction argument in the slave configuration
> call to determine whether we should report and fail an invalid
> configuration. Eventually this will be removed.
>
> * This has only been compile tested. Test feedback welcomed. *
>
> drivers/dma/amba-pl08x.c | 196 +++++++++++++++++++++++++++++---------------
> include/linux/amba/pl08x.h | 84 +------------------
> 2 files changed, 134 insertions(+), 146 deletions(-)
>
After applying series 1-6 (as well as with 1-7), my just posted LPC32xx
NAND drivers have problems mounting the MTD (basically, NAND page reads,
DMA dev to mem from NAND controller internal buffers).
* SLC driver says:
lpc32xx-nand 20020000.flash: FIFO not empty!
lpc32xx-nand 20020000.flash: FIFO held data too long
lpc32xx-nand 20020000.flash: DMA FIFO failure
* MLC driver just gets bad data resulting in detected bad blocks.
Without the patches, they work as tested.
Any hints, before I find the time to sort out all the details with
amba-pl08x?
Thanks,
Roland
next prev parent reply other threads:[~2012-05-16 12:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 11:04 [RFC] pl08x: don't use dma_slave_config direction argument Russell King - ARM Linux
2012-05-16 11:05 ` [PATCH 1/6] DMA: PL08x: move private data structures into amba-pl08x.c Russell King
2012-05-21 18:50 ` Linus Walleij
2012-05-16 11:05 ` [PATCH 2/6] DMA: PL08x: get src/dst addr direct from dma_slave_config struct Russell King
2012-05-16 11:05 ` [PATCH 3/6] DMA: PL08x: get rid of device_fc in struct pl08x_dma_chan Russell King
2012-05-16 11:06 ` [PATCH 4/6] DMA: PL08x: move the bus and increment selection to dma prepare function Russell King
2012-05-16 11:06 ` [PATCH 5/6] DMA: PL08x: extract function to to generate cctl values Russell King
2012-05-16 11:06 ` [PATCH 6/6] DMA: PL08x: ignore 'direction' argument in dma_slave_config Russell King
2012-05-16 11:17 ` [RFC] pl08x: don't use dma_slave_config direction argument Russell King - ARM Linux
2012-05-16 11:59 ` Linus Walleij
2012-05-16 12:10 ` Russell King - ARM Linux
2012-05-17 10:42 ` Russell King - ARM Linux
2012-05-18 15:47 ` Olof Johansson
2012-05-21 7:06 ` Linus Walleij
2012-05-21 7:03 ` Linus Walleij
2012-05-16 12:24 ` Roland Stigge [this message]
2012-05-16 12:52 ` Russell King - ARM Linux
2012-05-16 13:04 ` Roland Stigge
2012-05-16 13:06 ` Roland Stigge
2012-05-16 13:17 ` Russell King - ARM Linux
2012-05-16 13:36 ` Roland Stigge
2012-05-17 9:17 ` Russell King - ARM Linux
2012-05-17 14:30 ` Russell King - ARM Linux
2012-05-21 7:12 ` Linus Walleij
2012-05-17 17:03 ` Russell King - ARM Linux
2012-05-21 7:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB39C62.3030305@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox