From: stigge@antcom•de (Roland Stigge)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC] pl08x: don't use dma_slave_config direction argument
Date: Wed, 16 May 2012 15:06:25 +0200 [thread overview]
Message-ID: <4FB3A651.2080601@antcom.de> (raw)
In-Reply-To: <4FB3A5E7.7060505@antcom.de>
On 05/16/2012 03:04 PM, Roland Stigge wrote:
> On 05/16/2012 02:52 PM, Russell King - ARM Linux wrote:
>>> * SLC driver says:
>>>
>>> lpc32xx-nand 20020000.flash: FIFO not empty!
>>> lpc32xx-nand 20020000.flash: FIFO held data too long
>>> lpc32xx-nand 20020000.flash: DMA FIFO failure
>>>
>>> Any hints, before I find the time to sort out all the details with
>>> amba-pl08x?
>>
>> Nothing jumps out; it would be useful if you could bisect the small
>> series - I did the conversion in small steps so it should be easy to
>> track down. And it shouldn't take too long to rebuild between each
>> iteration. Whatever it is, it's probably going to be a stupid mistake
>> somewhere.
>
> The problem first appears with patch #4.
FYI: My pl08x is configured via platform data like this:
static struct pl08x_channel_data pl08x_slave_channels[] = {
{
.bus_id = "nand-slc",
.min_signal = 1, /* SLC NAND Flash */
.max_signal = 1,
.periph_buses = PL08X_AHB1,
},
{
.bus_id = "nand-mlc",
.min_signal = 12, /* MLC NAND Flash */
.max_signal = 12,
.periph_buses = PL08X_AHB1,
},
};
static int pl08x_get_signal(struct pl08x_dma_chan *ch) {
return ch->cd->min_signal;
}
static void pl08x_put_signal(struct pl08x_dma_chan *ch) {
}
static struct pl08x_platform_data pl08x_pd = {
.slave_channels = &pl08x_slave_channels[0],
.num_slave_channels = 2,
.get_signal = &pl08x_get_signal,
.put_signal = &pl08x_put_signal,
.lli_buses = PL08X_AHB1,
.mem_buses = PL08X_AHB1,
};
next prev parent reply other threads:[~2012-05-16 13:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 11:04 [RFC] pl08x: don't use dma_slave_config direction argument Russell King - ARM Linux
2012-05-16 11:05 ` [PATCH 1/6] DMA: PL08x: move private data structures into amba-pl08x.c Russell King
2012-05-21 18:50 ` Linus Walleij
2012-05-16 11:05 ` [PATCH 2/6] DMA: PL08x: get src/dst addr direct from dma_slave_config struct Russell King
2012-05-16 11:05 ` [PATCH 3/6] DMA: PL08x: get rid of device_fc in struct pl08x_dma_chan Russell King
2012-05-16 11:06 ` [PATCH 4/6] DMA: PL08x: move the bus and increment selection to dma prepare function Russell King
2012-05-16 11:06 ` [PATCH 5/6] DMA: PL08x: extract function to to generate cctl values Russell King
2012-05-16 11:06 ` [PATCH 6/6] DMA: PL08x: ignore 'direction' argument in dma_slave_config Russell King
2012-05-16 11:17 ` [RFC] pl08x: don't use dma_slave_config direction argument Russell King - ARM Linux
2012-05-16 11:59 ` Linus Walleij
2012-05-16 12:10 ` Russell King - ARM Linux
2012-05-17 10:42 ` Russell King - ARM Linux
2012-05-18 15:47 ` Olof Johansson
2012-05-21 7:06 ` Linus Walleij
2012-05-21 7:03 ` Linus Walleij
2012-05-16 12:24 ` Roland Stigge
2012-05-16 12:52 ` Russell King - ARM Linux
2012-05-16 13:04 ` Roland Stigge
2012-05-16 13:06 ` Roland Stigge [this message]
2012-05-16 13:17 ` Russell King - ARM Linux
2012-05-16 13:36 ` Roland Stigge
2012-05-17 9:17 ` Russell King - ARM Linux
2012-05-17 14:30 ` Russell King - ARM Linux
2012-05-21 7:12 ` Linus Walleij
2012-05-17 17:03 ` Russell King - ARM Linux
2012-05-21 7:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB3A651.2080601@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox