From: jgq516@gmail•com (Xiao Jiang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] watchdog: omap_wdt: add device tree support
Date: Wed, 30 May 2012 11:18:09 +0800 [thread overview]
Message-ID: <4FC59171.8040009@gmail.com> (raw)
In-Reply-To: <4FC51008.1050004@ti.com>
Jon Hunter wrote:
> On 05/25/2012 05:42 AM, jgq516 at gmail.com wrote:
>
>> From: Xiao Jiang <jgq516@gmail•com>
>>
>> Add device table for omap_wdt to support dt.
>>
>> Signed-off-by: Xiao Jiang <jgq516@gmail•com>
>> ---
>> drivers/watchdog/omap_wdt.c | 8 ++++++++
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
>> index 8285d65..d98c615 100644
>> --- a/drivers/watchdog/omap_wdt.c
>> +++ b/drivers/watchdog/omap_wdt.c
>> @@ -430,6 +430,13 @@ static int omap_wdt_resume(struct platform_device *pdev)
>> #define omap_wdt_resume NULL
>> #endif
>>
>> +static const struct of_device_id omap_wdt_of_match[] = {
>> + { .compatible = "ti,omap3-wdt", },
>> + { .compatible = "ti,omap4-wdt", },
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(of, omap_wdt_of_match);
>> +
>> static struct platform_driver omap_wdt_driver = {
>> .probe = omap_wdt_probe,
>> .remove = __devexit_p(omap_wdt_remove),
>> @@ -439,6 +446,7 @@ static struct platform_driver omap_wdt_driver = {
>> .driver = {
>> .owner = THIS_MODULE,
>> .name = "omap_wdt",
>> + .of_match_table = omap_wdt_of_match,
>> },
>> };
>>
>>
>
> I think we need to add some code to the probe function that calls
> of_match_device() and ensures we find a match. For example ...
>
> if (of_have_populated_dt())
> if (!of_match_device(omap_wdt_of_match, &pdev->dev))
> return -EINVAL;
>
>
Will add it in v2, thanks for suggestion.
Regards,
Xiao
> Cheers
> Jon
>
next prev parent reply other threads:[~2012-05-30 3:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 10:42 [PATCH 0/3] omap3/omap4: add device tree support for wdt jgq516 at gmail.com
2012-05-25 10:42 ` [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4 jgq516 at gmail.com
2012-05-29 17:52 ` Jon Hunter
2012-05-30 3:19 ` Xiao Jiang
2012-05-30 14:42 ` Jon Hunter
2012-05-31 5:51 ` Xiao Jiang
2012-05-31 14:55 ` Jon Hunter
2012-05-31 20:59 ` Cousson, Benoit
2012-05-25 10:42 ` [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support jgq516 at gmail.com
2012-05-29 17:53 ` Jon Hunter
2012-05-25 10:42 ` [PATCH 3/3] watchdog: omap_wdt: add device tree support jgq516 at gmail.com
2012-05-29 18:06 ` Jon Hunter
2012-05-30 3:18 ` Xiao Jiang [this message]
2012-05-30 7:54 ` Cousson, Benoit
2012-05-30 10:14 ` Xiao Jiang
2012-05-30 10:31 ` Xiao Jiang
2012-05-30 15:03 ` Jon Hunter
2012-05-30 15:30 ` Cousson, Benoit
2012-05-30 16:12 ` Jon Hunter
2012-05-29 17:47 ` [PATCH 0/3] omap3/omap4: add device tree support for wdt Jon Hunter
2012-05-30 10:14 ` Xiao Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC59171.8040009@gmail.com \
--to=jgq516@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox