From: jon-hunter@ti•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4
Date: Wed, 30 May 2012 09:42:45 -0500 [thread overview]
Message-ID: <4FC631E5.9080000@ti.com> (raw)
In-Reply-To: <4FC591C9.2050004@gmail.com>
On 05/29/2012 10:19 PM, Xiao Jiang wrote:
> Jon Hunter wrote:
>> On 05/25/2012 05:42 AM, jgq516 at gmail.com wrote:
>>
>>> From: Xiao Jiang <jgq516@gmail•com>
>>>
>>> Add wdt node to support dt.
>>>
>>> Signed-off-by: Xiao Jiang <jgq516@gmail•com>
>>> ---
>>> arch/arm/boot/dts/omap3.dtsi | 5 +++++
>>> arch/arm/boot/dts/omap4.dtsi | 5 +++++
>>> 2 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>>> index 99474fa..039df5c 100644
>>> --- a/arch/arm/boot/dts/omap3.dtsi
>>> +++ b/arch/arm/boot/dts/omap3.dtsi
>>> @@ -215,5 +215,10 @@
>>> compatible = "ti,omap3-hsmmc";
>>> ti,hwmods = "mmc3";
>>> };
>>> +
>>> + wdt: wdt at 48314000{
>>>
>>
>> Minor comment, may be call this wdt2 as this is watchdog timer 2. Also
>> ass a space between the address and the "{".
>>
>>
> Ok, will change it to "wdt2: wdt at 48314000 {".
>>> + compatible = "ti,omap3-wdt";
>>> + ti,hwmods = "wd_timer2";
>>> + };
>>> };
>>> };
>>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>>> index 359c497..d01403d 100644
>>> --- a/arch/arm/boot/dts/omap4.dtsi
>>> +++ b/arch/arm/boot/dts/omap4.dtsi
>>> @@ -272,5 +272,10 @@
>>> ti,hwmods = "mmc5";
>>> ti,needs-special-reset;
>>> };
>>> +
>>> + wdt: wdt at 4a314000{
>>>
>>
>> Same as above.
>>
>>
> Ditto.
>>> + compatible = "ti,omap4-wdt";
>>> + ti,hwmods = "wd_timer2";
>>> + };
>>> };
>>> };
>>>
>>
>> Also we should add some documentation to describe the binding. Here it
>> is very simple, but nonetheless we should have something as we have for
>> gpio [1].
>>
>>
> Thanks for reminding, how about below patch?
>
> diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> new file mode 100644
> index 0000000..4272d06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt
> @@ -0,0 +1,15 @@
> +TI Watchdog Timer (WDT) Controller for OMAP
> +
> +Required properties:
> +- compatible:
> + - "ti,omap2-wdt" for OMAP2
> + - "ti,omap3-wdt" for OMAP3
> + - "ti,omap4-wdt" for OMAP4
> +- ti,hwmods: Name of the hwmod associated to the WDT
> +
> +Examples:
> +
> +wdt2: wdt at 73f98000 {
> + compatible = "ti,omap4-wdt";
> + ti,hwmods = "wd_timer2";
> +};
Yes looks good. Thanks! Minor nit-pick in the example I would just copy
the omap4 node completely with the actual omap4 address :-)
Cheers
Jon
next prev parent reply other threads:[~2012-05-30 14:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 10:42 [PATCH 0/3] omap3/omap4: add device tree support for wdt jgq516 at gmail.com
2012-05-25 10:42 ` [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4 jgq516 at gmail.com
2012-05-29 17:52 ` Jon Hunter
2012-05-30 3:19 ` Xiao Jiang
2012-05-30 14:42 ` Jon Hunter [this message]
2012-05-31 5:51 ` Xiao Jiang
2012-05-31 14:55 ` Jon Hunter
2012-05-31 20:59 ` Cousson, Benoit
2012-05-25 10:42 ` [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support jgq516 at gmail.com
2012-05-29 17:53 ` Jon Hunter
2012-05-25 10:42 ` [PATCH 3/3] watchdog: omap_wdt: add device tree support jgq516 at gmail.com
2012-05-29 18:06 ` Jon Hunter
2012-05-30 3:18 ` Xiao Jiang
2012-05-30 7:54 ` Cousson, Benoit
2012-05-30 10:14 ` Xiao Jiang
2012-05-30 10:31 ` Xiao Jiang
2012-05-30 15:03 ` Jon Hunter
2012-05-30 15:30 ` Cousson, Benoit
2012-05-30 16:12 ` Jon Hunter
2012-05-29 17:47 ` [PATCH 0/3] omap3/omap4: add device tree support for wdt Jon Hunter
2012-05-30 10:14 ` Xiao Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC631E5.9080000@ti.com \
--to=jon-hunter@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox