From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level
Date: Thu, 14 Jun 2012 11:06:41 +0300 [thread overview]
Message-ID: <4FD99B91.9030705@compulab.co.il> (raw)
In-Reply-To: <4FD98DDA.9050806@windriver.com>
On 06/14/12 10:08, Zumeng Chen wrote:
> ? 2012?06?14? 14:44, Igor Grinberg ??:
>> On 06/14/12 07:46, Zumeng Chen wrote:
>>> > ? 2012?06?13? 20:18, Hiremath, Vaibhav ??:
>>>> >> On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:
>>>>> >>> From: Zumeng Chen<zumeng.chen@windriver•com>
>>>>> >>>
>>>>> >>> If we don't set proper debouce time for ads7846, then there are
>>>>> >>> flooded interrupt counters of ads7846 responding to one time
>>>>> >>> touch on screen, so the driver couldn't work well.
>>>>> >>>
>>>>> >>> And since most OMAP3 series boards pass NULL pointer of board_pdata
>>>>> >>> to omap_ads7846_init, so it's more proper to set it in driver level
>>>>> >>> after having gpio_request done.
>>>>> >>>
>>>>> >>> This patch has been validated on 3530evm.
>>>>> >>>
>>>>> >>> Signed-off-by: Zumeng Chen<zumeng.chen@windriver•com>
>>>>> >>> Signed-off-by: Syed Mohammed Khasim<khasim@ti•com>
>>>>> >>> ---
>>>>> >>> drivers/input/touchscreen/ads7846.c | 4 ++++
>>>>> >>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>>>> >>>
>>>>> >>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>>>>> >>> index f02028e..459ff29 100644
>>>>> >>> --- a/drivers/input/touchscreen/ads7846.c
>>>>> >>> +++ b/drivers/input/touchscreen/ads7846.c
>>>>> >>> @@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
>>>>> >>> }
>>>>> >>>
>>>>> >>> ts->gpio_pendown = pdata->gpio_pendown;
>>>>> >>> +#ifdef CONFIG_ARCH_OMAP3
>>>>> >>> + /* 310 means about 10 microsecond for omap3 */
>>>>> >>> + gpio_set_debounce(pdata->gpio_pendown, 310);
>>>>> >>> +#endif
>>>>> >>>
>>>> >> Zumeng,
>>>> >>
>>>> >> With my sign-off you are changing the original code, that too
>>>> >> without my sign-off and ack.
>>>> >> I wouldn't mind you to submit patches from my tree, but the expectation is
>>>> >> if you are changing the original code, it should be under your sign-off.
>>> > Thanks, good to learn. I'll remove in next time.
>>>> >> Coming to the patch, #ifdef in driver is not recommended, and this 10msec
>>>> >> delay is specific to OMAP GPIO and driver should not be aware of this,
>>>> >> that's where you will find the original patch handling it in board file.
>>> > According to the git blame of the board-omap3evm.c I think
>>> > 96974a24 did a good thing to all the related codes for omap3
>>> > boards. So I think we can call board and driver as BSP level :-)
>>> >
>>> > If #ifdef in driver can save many codes, I guess it's deserved.
>> No, platform/board specific ifdefs in the generic driver code are never
>> deserved.
>> How about the attached patch, does it fix the problem for you?
> Sorry Igor, I just read your patch, yes, most are there, and we
> just have to set get_pendown_state as you early said. Really
> *thanks* for your drive :)
No, with my patch, you don't need the get_pendown_state() and
you don't need to change the board-omap3evm.c ADS7846 related code.
So, I'm going to submit my patch properly.
>
> Regards,
> Zumeng
>> -- Regards, Igor.
>> ads7846.patch
>>
>>
>> diff --git a/arch/arm/mach-omap2/common-board-devices.c b/arch/arm/mach-omap2/common-board-devices.c
>> index 1706ebc..c187586 100644
>> --- a/arch/arm/mach-omap2/common-board-devices.c
>> +++ b/arch/arm/mach-omap2/common-board-devices.c
>> @@ -63,28 +63,30 @@ void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce,
>> struct spi_board_info *spi_bi = &ads7846_spi_board_info;
>> int err;
>>
>> - if (board_pdata && board_pdata->get_pendown_state) {
>> - err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown");
>> - if (err) {
>> - pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err);
>> - return;
>> - }
>> - gpio_export(gpio_pendown, 0);
>> -
>> - if (gpio_debounce)
>> - gpio_set_debounce(gpio_pendown, gpio_debounce);
>> + err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown");
>> + if (err) {
>> + pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err);
>> + return;
>> }
>>
>> + if (gpio_debounce)
>> + gpio_set_debounce(gpio_pendown, gpio_debounce);
>> +
>> spi_bi->bus_num = bus_num;
>> spi_bi->irq = gpio_to_irq(gpio_pendown);
>>
>> if (board_pdata) {
>> board_pdata->gpio_pendown = gpio_pendown;
>> spi_bi->platform_data = board_pdata;
>> + if (board_pdata->get_pendown_state)
>> + gpio_export(gpio_pendown, 0);
>> } else {
>> ads7846_config.gpio_pendown = gpio_pendown;
>> }
>>
>> + if (!board_pdata || (board_pdata && !board_pdata->get_pendown_state))
>> + gpio_free(gpio_pendown);
>> +
>> spi_register_board_info(&ads7846_spi_board_info, 1);
>> }
>> #else
>
--
Regards,
Igor.
next prev parent reply other threads:[~2012-06-14 8:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <zumeng.chen@gmail.com>
2012-06-11 14:00 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Zumeng Chen
2012-06-11 14:00 ` [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-11 14:57 ` Jon Hunter
2012-06-12 2:22 ` Zumeng Chen
2012-06-11 14:00 ` [PATCH 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-11 14:00 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-11 14:00 ` [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set Zumeng Chen
2012-06-11 15:03 ` Jon Hunter
2012-06-12 2:30 ` Zumeng Chen
2012-06-12 16:27 ` Jon Hunter
2012-06-12 16:54 ` Zumeng Chen
2012-06-12 7:56 ` Igor Grinberg
2012-06-11 14:00 ` [PATCH 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-11 14:37 ` Igor Grinberg
2012-06-12 2:49 ` Zumeng Chen
2012-06-12 7:53 ` Igor Grinberg
2012-06-12 6:47 ` Tony Lindgren
2012-06-12 16:37 ` Zumeng Chen
2012-06-13 12:55 ` Tony Lindgren
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:57 ` Zumeng Chen
2012-06-11 14:51 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Jon Hunter
2012-06-12 2:31 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH v2 0/5] ARM " Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-13 7:57 ` Igor Grinberg
2012-06-13 8:16 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-13 8:16 ` Igor Grinberg
2012-06-13 8:23 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 4/5] ARM: OMAP3EVM: cosmetic fixes for parent clk set Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-13 7:51 ` Igor Grinberg
2012-06-13 9:03 ` Zumeng Chen
2012-06-13 10:13 ` Igor Grinberg
2012-06-16 13:27 ` Marek Vasut
2012-06-13 12:18 ` Hiremath, Vaibhav
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:46 ` Zumeng Chen
2012-06-14 6:31 ` Hiremath, Vaibhav
2012-06-14 6:59 ` Zumeng Chen
2012-06-16 0:15 ` zumeng.chen
2012-06-20 5:28 ` Zumeng Chen
2012-06-14 6:44 ` Igor Grinberg
2012-06-14 7:08 ` Zumeng Chen
2012-06-14 8:06 ` Igor Grinberg [this message]
2012-06-14 8:18 ` Zumeng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD99B91.9030705@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox