From: zumeng.chen@windriver•com (Zumeng Chen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level
Date: Thu, 14 Jun 2012 12:46:55 +0800 [thread overview]
Message-ID: <4FD96CBF.5040106@windriver.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA4F07F@DBDE01.ent.ti.com>
? 2012?06?13? 20:18, Hiremath, Vaibhav ??:
> On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:
>> From: Zumeng Chen<zumeng.chen@windriver•com>
>>
>> If we don't set proper debouce time for ads7846, then there are
>> flooded interrupt counters of ads7846 responding to one time
>> touch on screen, so the driver couldn't work well.
>>
>> And since most OMAP3 series boards pass NULL pointer of board_pdata
>> to omap_ads7846_init, so it's more proper to set it in driver level
>> after having gpio_request done.
>>
>> This patch has been validated on 3530evm.
>>
>> Signed-off-by: Zumeng Chen<zumeng.chen@windriver•com>
>> Signed-off-by: Syed Mohammed Khasim<khasim@ti•com>
>> ---
>> drivers/input/touchscreen/ads7846.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index f02028e..459ff29 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784
>> }
>>
>> ts->gpio_pendown = pdata->gpio_pendown;
>> +#ifdef CONFIG_ARCH_OMAP3
>> + /* 310 means about 10 microsecond for omap3 */
>> + gpio_set_debounce(pdata->gpio_pendown, 310);
>> +#endif
>>
> Zumeng,
>
> With my sign-off you are changing the original code, that too
> without my sign-off and ack.
> I wouldn't mind you to submit patches from my tree, but the expectation is
> if you are changing the original code, it should be under your sign-off.
Thanks, good to learn. I'll remove in next time.
> Coming to the patch, #ifdef in driver is not recommended, and this 10msec
> delay is specific to OMAP GPIO and driver should not be aware of this,
> that's where you will find the original patch handling it in board file.
According to the git blame of the board-omap3evm.c I think
96974a24 did a good thing to all the related codes for omap3
boards. So I think we can call board and driver as BSP level :-)
If #ifdef in driver can save many codes, I guess it's deserved.
Regards,
Zumeng
> Thanks,
> Vaibhav
>> } else {
>> dev_err(&spi->dev, "no get_pendown_state nor gpio_pendown?\n");
>> --
>> 1.7.5.4
>>
>>
next prev parent reply other threads:[~2012-06-14 4:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <zumeng.chen@gmail.com>
2012-06-11 14:00 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Zumeng Chen
2012-06-11 14:00 ` [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-11 14:57 ` Jon Hunter
2012-06-12 2:22 ` Zumeng Chen
2012-06-11 14:00 ` [PATCH 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-11 14:00 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-11 14:00 ` [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set Zumeng Chen
2012-06-11 15:03 ` Jon Hunter
2012-06-12 2:30 ` Zumeng Chen
2012-06-12 16:27 ` Jon Hunter
2012-06-12 16:54 ` Zumeng Chen
2012-06-12 7:56 ` Igor Grinberg
2012-06-11 14:00 ` [PATCH 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-11 14:37 ` Igor Grinberg
2012-06-12 2:49 ` Zumeng Chen
2012-06-12 7:53 ` Igor Grinberg
2012-06-12 6:47 ` Tony Lindgren
2012-06-12 16:37 ` Zumeng Chen
2012-06-13 12:55 ` Tony Lindgren
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:57 ` Zumeng Chen
2012-06-11 14:51 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Jon Hunter
2012-06-12 2:31 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH v2 0/5] ARM " Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-13 7:57 ` Igor Grinberg
2012-06-13 8:16 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-13 8:16 ` Igor Grinberg
2012-06-13 8:23 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 4/5] ARM: OMAP3EVM: cosmetic fixes for parent clk set Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-13 7:51 ` Igor Grinberg
2012-06-13 9:03 ` Zumeng Chen
2012-06-13 10:13 ` Igor Grinberg
2012-06-16 13:27 ` Marek Vasut
2012-06-13 12:18 ` Hiremath, Vaibhav
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:46 ` Zumeng Chen [this message]
2012-06-14 6:31 ` Hiremath, Vaibhav
2012-06-14 6:59 ` Zumeng Chen
2012-06-16 0:15 ` zumeng.chen
2012-06-20 5:28 ` Zumeng Chen
2012-06-14 6:44 ` Igor Grinberg
2012-06-14 7:08 ` Zumeng Chen
2012-06-14 8:06 ` Igor Grinberg
2012-06-14 8:18 ` Zumeng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD96CBF.5040106@windriver.com \
--to=zumeng.chen@windriver$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox