From: mkl@blackshift•org (Marc Kleine-Budde)
To: linux-arm-kernel@lists•infradead.org
Subject: Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment)
Date: Mon, 18 Jun 2012 10:28:54 +0200 [thread overview]
Message-ID: <4FDEE6C6.2060101@blackshift.org> (raw)
In-Reply-To: <20120618080449.GK4799@lunn.ch>
Hello Sebastian,
On 06/18/2012 10:04 AM, Andrew Lunn wrote:
>> BTW: I'm hacking on the dove clock support, I noticed that dove can make
>> use of the same ethernet and pci phy shutdown functions than kirkwood.
>> What about moving kirkwood_register_gate_fn and subfunctions to plat-orion?
>
> Please coordinate with Sebastian.hesselbarth
> <Sebastian.hesselbarth@googlemail•com> He has done some work in the
> same area.
>
> I would probably move the kirkwood_register_gate_fn() stuff to
> drivers/clk. Also, the pcie and sata shutdown functions need
> generalizing if they are the be re-used. The address map on Dove is
> different to Kirkwood, so the registers are in different places.
Sure, the address layout is different, but that can be made generic in a
second step. Maybe we need a private pointer in the gate_fn struct.
BTW: who will enable the clocks that have been disabled via the
sata/pcie shutdown functions?
cheers, Marc
next prev parent reply other threads:[~2012-06-18 8:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 0:07 RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment Marc Kleine-Budde
2012-06-18 7:42 ` Andrew Lunn
2012-06-18 7:54 ` Marc Kleine-Budde
2012-06-18 8:04 ` Andrew Lunn
2012-06-18 8:28 ` Marc Kleine-Budde [this message]
2012-06-18 8:43 ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Andrew Lunn
2012-06-18 9:42 ` Dove clock support Sebastian Hesselbarh
2012-06-18 9:54 ` Marc Kleine-Budde
2012-06-18 10:01 ` Sebastian Hesselbarh
2012-06-18 10:11 ` Andrew Lunn
2012-06-18 20:38 ` Sebastian Hesselbarh
2012-06-19 19:25 ` Andrew Lunn
2012-06-19 19:31 ` Sebastian Hesselbarh
2012-06-19 19:35 ` Andrew Lunn
2012-06-18 11:50 ` Marc Kleine-Budde
2012-06-18 21:41 ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Simon Baatz
2012-06-18 22:10 ` Dove clock support Sebastian Hesselbarh
2012-06-19 19:32 ` Andrew Lunn
2012-06-19 20:42 ` Simon Baatz
2012-06-19 20:43 ` Marc Kleine-Budde
2012-06-19 20:55 ` Sebastian Hesselbarh
2012-06-19 23:06 ` Simon Baatz
2012-06-20 5:43 ` Andrew Lunn
2012-06-20 5:51 ` Andrew Lunn
2012-06-24 15:17 ` Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDEE6C6.2060101@blackshift.org \
--to=mkl@blackshift$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox