From: mkl@blackshift•org (Marc Kleine-Budde)
To: linux-arm-kernel@lists•infradead.org
Subject: Dove clock support
Date: Mon, 18 Jun 2012 11:54:42 +0200 [thread overview]
Message-ID: <4FDEFAE2.7000303@blackshift.org> (raw)
In-Reply-To: <4FDEF7E9.4030504@googlemail.com>
On 06/18/2012 11:42 AM, Sebastian Hesselbarh wrote:
> On 06/18/2012 10:43 AM, Andrew Lunn wrote:
>>> Sure, the address layout is different, but that can be made generic in a
>>> second step. Maybe we need a private pointer in the gate_fn struct.
>>
>> Yes, something like that.
>
> You need to pass at least the controllers base address. Everything else
> is common - IIRC kirkwood has two SATA, dove only one. Moreover the base
> addresses for the second are not defined, yet.
>
> Also ge-phy has to be connected with ge-clk, too. But for dove this is
> a clk gate while kirkwood can shut it down somewhere else. I guess it
> can be handled like sata/pcie on kirkwood.
The PHY is a clock gate so I'm handling it via:
> ge = dove_register_gate("ge0", CLOCK_GATING_GBE_BIT | CLOCK_GATING_GIGA_PHY_BIT);
So no gate_fn needed.
>>> BTW: who will enable the clocks that have been disabled via the
>>> sata/pcie shutdown functions?
>>
>> This is potentially a problem when the SATA driver is built as a
>> kernel module. There is no code that i know of to turn the SATA PHYs
>> back on again. I think this has been broken like this for a long
>> time...
>
> IMHO the driver should take care of enabling clk and PHYs. In my
> understanding of the common clock framework both will be disabled
> if no driver requests it.
But the current drivers don't enable clk and PHYs? But if I understand
Andrew correct, this was the case all the time.
Cheers, Marc
next prev parent reply other threads:[~2012-06-18 9:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 0:07 RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment Marc Kleine-Budde
2012-06-18 7:42 ` Andrew Lunn
2012-06-18 7:54 ` Marc Kleine-Budde
2012-06-18 8:04 ` Andrew Lunn
2012-06-18 8:28 ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Marc Kleine-Budde
2012-06-18 8:43 ` Andrew Lunn
2012-06-18 9:42 ` Dove clock support Sebastian Hesselbarh
2012-06-18 9:54 ` Marc Kleine-Budde [this message]
2012-06-18 10:01 ` Sebastian Hesselbarh
2012-06-18 10:11 ` Andrew Lunn
2012-06-18 20:38 ` Sebastian Hesselbarh
2012-06-19 19:25 ` Andrew Lunn
2012-06-19 19:31 ` Sebastian Hesselbarh
2012-06-19 19:35 ` Andrew Lunn
2012-06-18 11:50 ` Marc Kleine-Budde
2012-06-18 21:41 ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Simon Baatz
2012-06-18 22:10 ` Dove clock support Sebastian Hesselbarh
2012-06-19 19:32 ` Andrew Lunn
2012-06-19 20:42 ` Simon Baatz
2012-06-19 20:43 ` Marc Kleine-Budde
2012-06-19 20:55 ` Sebastian Hesselbarh
2012-06-19 23:06 ` Simon Baatz
2012-06-20 5:43 ` Andrew Lunn
2012-06-20 5:51 ` Andrew Lunn
2012-06-24 15:17 ` Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDEFAE2.7000303@blackshift.org \
--to=mkl@blackshift$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox