From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 03/10] ARM: OMAP2+: PM QoS: manage the per-device latency constraints in hwmod
Date: Wed, 20 Jun 2012 15:59:21 +0530 [thread overview]
Message-ID: <4FE1A601.9000802@ti.com> (raw)
In-Reply-To: <1339686361-11526-4-git-send-email-j-pihet@ti.com>
On Thursday 14 June 2012 08:35 PM, Jean Pihet wrote:
> Call the per-device PM QoS functions of the power domain code from the
> hwmod layer, in order to apply the constraints requested to a device.
>
> While at it, correct the functions kerneldoc.
Shouldn't this patch be just merged with PATCH 02/10?
>
> Signed-off-by: Jean Pihet<j-pihet@ti•com>
> ---
> arch/arm/mach-omap2/omap_hwmod.c | 22 ++++++----------------
> 1 files changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index cc173d9..4f43e0c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -3302,15 +3302,13 @@ ohsps_unlock:
> }
>
> /**
> - * omap_hwmod_set_wakeuplat_constraint - set/release a wake-up latency
> + * omap_hwmod_set_wakeuplat_constraint - Set or update a wake-up latency
> * constraint
> * @oh: struct omap_hwmod* to which the target device belongs to.
> * @cookie: identifier of the constraints list for @oh.
> * @min_latency: the minimum allowed wake-up latency for @oh.
> *
> - * Sets a wakeup latency contraint. (To remove a wakeup latency
> - * constraint, call omap_hwmod_remove_wakeuplat_constraint()).
> - * Returns the return value from pwrdm_wakeuplat_remove_constraint(),
> + * Returns the return value from pwrdm_wakeuplat_update_constraint(),
> * or -EINVAL in case of invalid parameters.
> */
> int omap_hwmod_set_wakeuplat_constraint(struct omap_hwmod *oh, void *cookie,
> @@ -3321,21 +3319,17 @@ int omap_hwmod_set_wakeuplat_constraint(struct omap_hwmod *oh, void *cookie,
> if (!pwrdm)
> return -EINVAL;
>
> - /*
> - * XXX Update to use pwrdm_wakeuplat_update_constraint() when
> - * that code is ready
> - */
> - return -EINVAL;
> + return pwrdm_wakeuplat_update_constraint(pwrdm, cookie, min_latency);
> }
>
> /**
> - * omap_hwmod_remove_wakeuplat_constraint - release a wake-up latency
> + * omap_hwmod_remove_wakeuplat_constraint - Release a wake-up latency
> * constraint
> * @oh: struct omap_hwmod* to which the target device belongs to.
> * @cookie: identifier of the constraints list for @oh.
> *
> * Removes a wakeup latency contraint. Returns the return value from
> - * pwrdm_wakeuplat_update_constraint(), or -EINVAL in case of invalid
> + * pwrdm_wakeuplat_remove_constraint(), or -EINVAL in case of invalid
> * parameters.
> */
> int omap_hwmod_remove_wakeuplat_constraint(struct omap_hwmod *oh, void *cookie)
> @@ -3345,11 +3339,7 @@ int omap_hwmod_remove_wakeuplat_constraint(struct omap_hwmod *oh, void *cookie)
> if (!pwrdm)
> return -EINVAL;
>
> - /*
> - * XXX Update to use pwrdm_wakeuplat_remove_constraint() when
> - * that code is ready
> - */
> - return -EINVAL;
> + return pwrdm_wakeuplat_remove_constraint(pwrdm, cookie);
> }
>
> /**
next prev parent reply other threads:[~2012-06-20 10:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 15:05 [PATCH v8 00/10] PM QoS: implement the OMAP low level constraints management code Jean Pihet
2012-06-14 15:05 ` [PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints Jean Pihet
2012-06-15 11:37 ` Jean Pihet
2012-07-19 9:12 ` Menon, Nishanth
2012-07-20 3:08 ` Menon, Nishanth
2012-06-14 15:05 ` [PATCH 02/10] ARM: OMAP2+: hwmod: manage the wake-up latency constraints Jean Pihet
2012-06-14 15:05 ` [PATCH 03/10] ARM: OMAP2+: PM QoS: manage the per-device latency constraints in hwmod Jean Pihet
2012-06-20 10:29 ` Rajendra Nayak [this message]
2012-06-20 11:38 ` Jean Pihet
2012-06-14 15:05 ` [PATCH 04/10] ARM: OMAP: omap_device: register to the per-device PM QoS framework Jean Pihet
2012-06-20 10:41 ` Rajendra Nayak
2012-07-19 9:21 ` Menon, Nishanth
2012-06-14 15:05 ` [PATCH 05/10] ARM: OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints Jean Pihet
2012-06-14 15:05 ` [PATCH 06/10] ARM: OMAP3: PM: cpuidle: default to C1 in next_valid_state Jean Pihet
2012-06-14 15:05 ` [PATCH 07/10] ARM: OMAP3: update cpuidle latency and threshold figures Jean Pihet
2012-06-20 11:01 ` Rajendra Nayak
2012-06-20 11:39 ` Jean Pihet
2012-06-14 15:05 ` [PATCH 08/10] ARM: OMAP3: powerdomain data: add wake-up latency figures Jean Pihet
2012-06-14 15:06 ` [PATCH 09/10] ARM: OMAP: convert I2C driver to PM QoS for latency constraints Jean Pihet
2012-06-14 15:06 ` [PATCH 10/10] ARM: OMAP: PM: remove the latency related functions from the API Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE1A601.9000802@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox