From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 08 Aug 2012 12:38:58 -0600 [thread overview]
Message-ID: <5022B242.1050001@wwwdotorg.org> (raw)
In-Reply-To: <1344389967-8465-9-git-send-email-linux@prisktech.co.nz>
On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Converted the existing arch-vt8500 gpio to a platform_device.
> Added support for WM8505 and WM8650 GPIO controllers.
> diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
> +static struct of_device_id vt8500_gpio_dt_ids[] = {
> + { .compatible = "via,vt8500-gpio", .data = &vt8500_data, },
> + { .compatible = "wm,wm8505-gpio", .data = &wm8505_data, },
> + { .compatible = "wm,wm8650-gpio", .data = &wm8650_data, },
> + { /* Sentinel */ },
> +};
> +
> +static int __devinit vt8500_gpio_probe(struct platform_device *pdev)
> +{
> + void __iomem *gpio_base;
> + struct device_node *np;
> + const struct of_device_id *of_id =
> + of_match_device(vt8500_gpio_dt_ids, &pdev->dev);
> +
> + if (!of_id) {
> + dev_err(&pdev->dev, "Failed to find gpio controller\n");
> + return -ENODEV;
> + }
> +
> + np = of_find_matching_node(NULL, vt8500_gpio_dt_ids);
Can't you use pdev->dev.of_node instead of searching for it again?
...
> + of_node_put(np);
If so, you could also remove that.
> +static int __init vt8500_gpio_init(void)
> +{
> + return platform_driver_probe(&vt8500_gpio_driver, &vt8500_gpio_probe);
> +}
> +
> +static void __exit vt8500_gpio_exit(void)
> +{
> + return platform_driver_unregister(&vt8500_gpio_driver);
> +}
> +
> +module_init(vt8500_gpio_init);
> +module_exit(vt8500_gpio_exit);
I think that's all just:
module_platform_driver(vt8500_gpio_driver);
(except that _init uses platform_driver_probe() rather than
platform_driver_register(), which seems unusual. I guess that explains
the of_find_matching_node() above too.)
> +MODULE_LICENSE("GPL");
That should be "GPL v2" given the license header.
next prev parent reply other threads:[~2012-08-08 18:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 1:39 [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08 1:39 ` [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-08 18:43 ` Stephen Warren
2012-08-08 20:08 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 2/8] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-08 1:39 ` [PATCH 3/8] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-08 1:39 ` [PATCH 4/8] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-08 1:39 ` [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-08 18:47 ` Stephen Warren
2012-08-08 19:37 ` Tony Prisk
2012-08-15 19:21 ` Stephen Warren
2012-08-08 1:39 ` [PATCH 6/8] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-08 18:58 ` Stephen Warren
2012-08-08 19:37 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 7/8] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-08 1:39 ` [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-08 9:11 ` [rtc-linux] " Linus Walleij
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 14:28 ` Linus Walleij
2012-08-08 19:46 ` Tony Prisk
2012-08-08 18:38 ` Stephen Warren [this message]
2012-08-08 19:17 ` Arnd Bergmann
2012-08-08 2:40 ` [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-19 1:22 ` Marcos Silva Cunha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5022B242.1050001@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox