From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb
Date: Wed, 15 Aug 2012 13:21:30 -0600 [thread overview]
Message-ID: <502BF6BA.9060407@wwwdotorg.org> (raw)
In-Reply-To: <76F764B079F92A4E843589C893D0A022D1DCA8D0@SERVER.prisktech.co.nz>
On 08/08/2012 01:37 PM, Tony Prisk wrote:
>> On 08/07/2012 07:39 PM, Tony Prisk wrote:
>>> Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device
>>> tree bindings.
>>> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
>
>>> + np = of_find_node_by_name(NULL, "display");
>>> + if (!np) {
>>> + pr_err("%s: No display description in Device Tree\n", __func__);
>>> + ret = -EINVAL;
>>> + goto failed_free_res;
>>> + }
>
>> I believe that using hard-coded node names is frowned upon. Better would
>> be to put a phandle into the display controller's node that points at
>> the node representing the display, e.g.:
>
> Will do.
I don't think this change made it into v2?
next prev parent reply other threads:[~2012-08-15 19:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 1:39 [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-08 1:39 ` [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-08 18:43 ` Stephen Warren
2012-08-08 20:08 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 2/8] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
2012-08-08 1:39 ` [PATCH 3/8] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-08 1:39 ` [PATCH 4/8] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-08 1:39 ` [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-08 18:47 ` Stephen Warren
2012-08-08 19:37 ` Tony Prisk
2012-08-15 19:21 ` Stephen Warren [this message]
2012-08-08 1:39 ` [PATCH 6/8] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-08 18:58 ` Stephen Warren
2012-08-08 19:37 ` Tony Prisk
2012-08-08 1:39 ` [PATCH 7/8] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
2012-08-08 1:39 ` [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-08 9:11 ` [rtc-linux] " Linus Walleij
2012-08-08 9:19 ` Arnd Bergmann
2012-08-08 14:28 ` Linus Walleij
2012-08-08 19:46 ` Tony Prisk
2012-08-08 18:38 ` Stephen Warren
2012-08-08 19:17 ` Arnd Bergmann
2012-08-08 2:40 ` [PATCH 0/8] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-19 1:22 ` Marcos Silva Cunha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BF6BA.9060407@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox