From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4 2/2] video: drm: exynos: Add device tree support
Date: Thu, 06 Sep 2012 13:05:31 +0200 [thread overview]
Message-ID: <5048837B.6020903@samsung.com> (raw)
In-Reply-To: <CAAQKjZNmizjZ-=JN9_AysPMPHTOh7eydfE_OCYE6-v0JAJMydw@mail.gmail.com>
Hi,
On 09/06/2012 09:21 AM, InKi Dae wrote:
>>> +Required properties:
>>> + - compatible: Should be "samsung,exynos5-fimd" or "samsung,exynos4-fb" for
>> Doesn't better to use single word? fimd or fb?. I think 'fb' is used
>> for framebuffer historically.
>> but now it's used both fb and drm, so fimd is neutral and architecture
>> specific.
>>
>> To do this, Modify arch-exynos first and update it at each drivers it properly.
>>
>> Thank you,
>> Kyungmin Park
>>
>
> I agree with Kyungmin but I'd like to use as is. the reason we used
> 'exynos4-fb' as device name, is for that it uses fimd driver's
> platform device commonly and gets fimd clock. so I think that dts file
> should be defined with hardware specific name but not driver name such
> as 'exynos4-fb'. but with this, we can't get fimd clock with device's
> name because 'exynos4-fb' is used as device name of fimd clock. so to
> use 'exynos4-fimd', we should modify the device name of fimd clock
> from 'exynos4-fb' to 'exynos4-fimd' and also ids definitions of
> s3c-fb and drm fimd driver. so my conclusion is that it merges this
I think it's good moment to put those things in order, i.e. use uniform
'compatible' names: "samsung,exynos4-fimd", "samsung,exynos5-fimd".
Platform device names are separate issue, but could perhaps be unified
at this time as well.
> patch set as is and then let's modify related things later.
> any opinions, welcome~ anytime.
>
> Thanks.
> Inki Dae
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-09-06 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 15:39 [PATCH V4 0/2] video: drm: Add Device tree support to DRM-FIMD Leela Krishna Amudala
2012-09-05 15:39 ` [PATCH V4 1/2] drm/exynos: add platform_device_id table and driver data for drm fimd Leela Krishna Amudala
2012-09-05 15:39 ` [PATCH V4 2/2] video: drm: exynos: Add device tree support Leela Krishna Amudala
2012-09-05 12:28 ` Kyungmin Park
2012-09-06 7:21 ` InKi Dae
2012-09-06 11:05 ` Sylwester Nawrocki [this message]
2012-09-07 3:46 ` Leela Krishna Amudala
2012-09-07 6:07 ` Inki Dae
2012-09-07 7:09 ` Inki Dae
2012-09-20 6:29 ` Inki Dae
2012-09-20 9:31 ` Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5048837B.6020903@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox