From: sebastian.hesselbarth@gmail•com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/4] arm: mvebu: move irq controller driver to drivers/irqchip
Date: Mon, 29 Oct 2012 10:38:59 +0100 [thread overview]
Message-ID: <508E4EB3.5060901@gmail.com> (raw)
In-Reply-To: <20121029102436.504d5053@skate>
On 10/29/2012 10:24 AM, Thomas Petazzoni wrote:
>> using ARCH_MVEBU for enabling irq-armada-370-xp here will lead to
>> incompatibilities with Orion SoCs when they move over to ARCH_MVEBU.
>
> Not really: the driver is probed depending on the DT compatible string.
> So we can perfectly have two irqchip drivers being enabled on
> ARCH_MVEBU.
I agreed but this will always build irq-armada-370-xp into the kernel
although I maybe want a orion-only kernel. Although multi-platform will
be great for ARM, I doubt that every kernel will be multi-platform?
>> With a Kconfig within drivers/irqchip you could define a
>> ARMADA_370_XP_IRQ and select that in MACH_ARMADA_370 and MACH_ARMADA_XP
>> or MACH_ARMADA_370_XP, which all already exist.
>
> But agreed, I could use MACH_ARMADA_370_XP. I don't know if we want to
> add Kconfig options for each irqchip driver.
Ok.
>> As soon as the patch is through, I can provide (and use) a irq-orion
>> based on irqchip. I can provide it earlier but to actually use it there
>> are still some other patches required on Dove. Other Orions could
>> switch now, I guess.
>
> Are you sure? The irqchip drivers only work for sub-architecture that
> are fully converted to the Device Tree. And I don't think all of
> mach-orion5x, mach-dove, mach-kirkwood and mach-mv78xx0 are converted
> to the DT.
Hmm, I do have an experimental branch of Dove with irqchip enabled that
works perfectly fine even with non-DT code in it. Actually, it is based
on 3.7-rc3 which means it is before your patches.
But the irq controller itself is referenced from DT, of course.
Sebastian
next prev parent reply other threads:[~2012-10-29 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 22:19 [PATCH v3] Introduce minimal irqchip infrastructure Thomas Petazzoni
2012-10-28 22:19 ` [PATCH v3 1/4] irqchip: add basic infrastructure Thomas Petazzoni
2012-10-28 22:19 ` [PATCH v3 2/4] arm: bcm2835: convert to the irqchip infrastructure Thomas Petazzoni
2012-11-06 16:56 ` Josh Cartwright
2012-11-06 17:54 ` Josh Cartwright
2012-11-07 7:09 ` Thomas Petazzoni
2012-10-28 22:19 ` [PATCH v3 3/4] arm: mvebu: move irq controller driver to drivers/irqchip Thomas Petazzoni
2012-10-29 9:18 ` Sebastian Hesselbarth
2012-10-29 9:24 ` Thomas Petazzoni
2012-10-29 9:38 ` Sebastian Hesselbarth [this message]
2012-10-29 9:50 ` Thomas Petazzoni
2012-10-29 10:03 ` Andrew Lunn
2012-10-28 22:19 ` [PATCH v3 4/4] irqchip: add to the directories part of the IRQ subsystem in MAINTAINERS Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E4EB3.5060901@gmail.com \
--to=sebastian.hesselbarth@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox