From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 5/6] sched: pack the idle load balance
Date: Fri, 2 Nov 2012 16:29:07 +0530 [thread overview]
Message-ID: <5093A77B.4060300@ti.com> (raw)
In-Reply-To: <CAKfTPtBsAJ4u265TzOz9qvL4d-eMmrVD-MtgG_Rri_2shGrPBQ@mail.gmail.com>
On Monday 29 October 2012 06:57 PM, Vincent Guittot wrote:
> On 24 October 2012 17:21, Santosh Shilimkar <santosh.shilimkar@ti•com> wrote:
>> On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote:
>>>
>>> Look for an idle CPU close the pack buddy CPU whenever possible.
>>
>> s/close/close to
>
> yes
>
>>
>>> The goal is to prevent the wake up of a CPU which doesn't share the power
>>> line of the pack CPU
>>>
>>> Signed-off-by: Vincent Guittot <vincent.guittot@linaro•org>
>>> ---
>>> kernel/sched/fair.c | 18 ++++++++++++++++++
>>> 1 file changed, 18 insertions(+)
>>>
>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>> index 6df53b5..f76acdc 100644
>>> --- a/kernel/sched/fair.c
>>> +++ b/kernel/sched/fair.c
>>> @@ -5158,7 +5158,25 @@ static struct {
>>>
>>> static inline int find_new_ilb(int call_cpu)
>>> {
>>> + struct sched_domain *sd;
>>> int ilb = cpumask_first(nohz.idle_cpus_mask);
>>> + int buddy = per_cpu(sd_pack_buddy, call_cpu);
>>> +
>>> + /*
>>> + * If we have a pack buddy CPU, we try to run load balance on a
>>> CPU
>>> + * that is close to the buddy.
>>> + */
>>> + if (buddy != -1)
>>> + for_each_domain(buddy, sd) {
>>> + if (sd->flags & SD_SHARE_CPUPOWER)
>>> + continue;
>>
>> Do you mean SD_SHARE_POWERLINE here ?
>
> No, I just don't want to take hyperthread level for ILB
>
>>
>>> +
>>> + ilb = cpumask_first_and(sched_domain_span(sd),
>>> + nohz.idle_cpus_mask);
>>> +
>>> + if (ilb < nr_cpu_ids)
>>> + break;
>>> + }
>>>
>>> if (ilb < nr_cpu_ids && idle_cpu(ilb))
>>> return ilb;
>>>
>> Can you please expand "idle CPU _close_ the pack buddy CPU" ?
>
> The goal is to packed the tasks on the pack buddy CPU so when the
> scheduler needs to start ILB, I try to wake up a CPU that is close to
> the buddy and preferably in the same cluster
>
I see your point now. Thanks for clarification.
Regards
santosh
next prev parent reply other threads:[~2012-11-02 10:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 7:43 [RFC 0/6] sched: packing small tasks Vincent Guittot
2012-10-07 7:43 ` [RFC 1/6] Revert "sched: introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2012-10-07 7:43 ` [RFC 2/6] sched: add a new SD SHARE_POWERLINE flag for sched_domain Vincent Guittot
2012-10-24 15:17 ` Santosh Shilimkar
2012-10-29 9:40 ` Vincent Guittot
2012-10-29 9:50 ` Vincent Guittot
2012-11-02 10:27 ` Santosh Shilimkar
2012-10-07 7:43 ` [RFC 3/6] sched: pack small tasks Vincent Guittot
2012-10-24 15:20 ` Santosh Shilimkar
2012-10-29 13:12 ` Vincent Guittot
2012-11-02 10:53 ` Santosh Shilimkar
2012-11-09 16:46 ` Morten Rasmussen
2012-11-12 13:13 ` Vincent Guittot
2012-11-12 9:30 ` Vincent Guittot
2012-11-09 17:13 ` Morten Rasmussen
2012-11-12 13:51 ` Vincent Guittot
2012-11-20 14:28 ` Morten Rasmussen
2012-11-20 16:59 ` Vincent Guittot
2012-10-07 7:43 ` [RFC 4/6] sched: secure access to other CPU statistics Vincent Guittot
2012-10-24 15:21 ` Santosh Shilimkar
2012-10-29 13:18 ` Vincent Guittot
2012-10-07 7:43 ` [RFC 5/6] sched: pack the idle load balance Vincent Guittot
2012-10-24 15:21 ` Santosh Shilimkar
2012-10-29 13:27 ` Vincent Guittot
2012-11-02 10:59 ` Santosh Shilimkar [this message]
2012-10-07 7:43 ` [RFC 6/6] ARM: sched: clear SD_SHARE_POWERLINE Vincent Guittot
2012-10-24 15:21 ` Santosh Shilimkar
2012-10-29 13:28 ` Vincent Guittot
2012-11-02 11:00 ` Santosh Shilimkar
2012-11-12 8:23 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093A77B.4060300@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox