From: hvaibhav@ti•com (Vaibhav Hiremath)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 08/15] ARM: OMAP2+: hwmod: Fix the omap_hwmod_addr_space for CPGMAC0
Date: Tue, 6 Nov 2012 14:59:45 +0530 [thread overview]
Message-ID: <5098D889.60909@ti.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EC00B9B@DBDE01.ent.ti.com>
On 11/5/2012 2:40 PM, Bedia, Vaibhav wrote:
> On Sun, Nov 04, 2012 at 20:54:17, Bedia, Vaibhav wrote:
>> On Sat, Nov 03, 2012 at 21:48:48, Shilimkar, Santosh wrote:
>>> On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote:
>>>> The first entry for CPGMAC0 should be ADDR_MAP_ON_INIT
>>>> instead of ADDR_TYPE_RT to ensure the omap hwmod code
>>>> maps the memory space at init and writes to the SYSCONFIG
>>>> registers.
>>>>
>>>> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti•com>
>>>> ---
>>> Sorry again similar question.
>>>
>>> Why CPGMAC0 should be mapped and sysconfig updated early ?
>>>
>>
>> Hmm I need to revisit this one. CPGMAC0 was not going to standby
>> without this. Maybe something else is wrong in the hwmod data and
>> needs fixing.
>>
>
> Ok I checked this one. The change I made was indirectly fixing another
> issue with the AM33xx hwmod data. am33xx_cpgmac0_addr_space[] has two
> entries and the SYSC register is part of the second entry. The function
> _find_mpu_rt_addr_space in omap_hwmod.c looks for the first entry with
> the flag ADDR_TYPE_RT flag. The change I made indirectly made the second
> entry in am33xx_cpgmac0_addr_space[] become the first memory space with
> the ADDR_TYPE_RT flag. Due to this the hwmod code wrote to the correct
> SYSC address of CPGMAC0 and the IP went to standby during bootup.
> After changing the order of the entries in am33xx_cpgmac0_addr_space[]
> things work fine.
>
Good catch.
Just a side note on this, driver expects the addresses in this order
only, first SS and then WR.
Thanks,
Vaibhav
> I'll make the changes in the next version.
>
> Regards,
> Vaibhav
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-11-06 9:29 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 12:32 [RFC 00/15] Add basic suspend-resume support for AM33XX Vaibhav Bedia
2012-11-02 12:32 ` [PATCH 01/15] ARM: OMAP2+: mailbox: Add an API for flushing the FIFO Vaibhav Bedia
2012-11-02 19:00 ` Tony Lindgren
2012-11-03 8:24 ` Bedia, Vaibhav
2012-11-03 16:03 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 14:59 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 02/15] ARM: OMAP2+: mailbox: Add support for AM33XX Vaibhav Bedia
2012-11-03 0:14 ` Russ Dill
2012-11-03 8:39 ` Bedia, Vaibhav
2012-11-03 13:48 ` Bedia, Vaibhav
2012-11-03 16:10 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 15:00 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 03/15] ARM: OMAP: mailbox: Convert to device_initcall Vaibhav Bedia
2012-11-03 16:12 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX Vaibhav Bedia
2012-11-05 6:58 ` Vaibhav Hiremath
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-06 6:06 ` Hiremath, Vaibhav
2012-11-06 7:19 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 05/15] ARM: OMAP2+: AM33XX: Update WKUP_M3 hwmod entry for reset status Vaibhav Bedia
2012-11-03 16:15 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 6:59 ` Vaibhav Hiremath
2012-11-02 12:32 ` [PATCH 06/15] ARM: OMAP2+: hwmod: Enable OCMCRAM registration in AM33XX Vaibhav Bedia
2012-11-03 16:16 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 7:23 ` Vaibhav Hiremath
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-06 6:07 ` Hiremath, Vaibhav
2012-11-02 12:32 ` [PATCH 07/15] ARM: OMAP2+: hwmod: Update the hwmod data for TPTCs " Vaibhav Bedia
2012-11-05 7:19 ` Vaibhav Hiremath
2012-11-02 12:32 ` [PATCH 08/15] ARM: OMAP2+: hwmod: Fix the omap_hwmod_addr_space for CPGMAC0 Vaibhav Bedia
2012-11-03 16:18 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 9:10 ` Bedia, Vaibhav
2012-11-06 9:29 ` Vaibhav Hiremath [this message]
2012-11-06 10:09 ` Bedia, Vaibhav
2012-11-06 13:08 ` Hiremath, Vaibhav
2012-11-06 13:46 ` Bedia, Vaibhav
2012-11-06 13:50 ` Benoit Cousson
2012-11-06 13:56 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 09/15] ARM: OMAP: AM33XX: Remove unnecessary include and use __ASSEMBLER__ macros Vaibhav Bedia
2012-11-03 16:29 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 10/15] ARM: OMAP2+: control: Add some AM33XX Control module registers Vaibhav Bedia
2012-11-02 12:32 ` [PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX Vaibhav Bedia
2012-11-03 11:43 ` Kevin Hilman
2012-11-03 12:47 ` Bedia, Vaibhav
2012-11-03 13:04 ` Kevin Hilman
2012-11-03 13:48 ` Bedia, Vaibhav
2012-11-05 18:03 ` Kevin Hilman
2012-11-05 21:59 ` Santosh Shilimkar
2012-11-06 14:38 ` Bedia, Vaibhav
2012-11-08 13:15 ` Bedia, Vaibhav
2012-11-06 14:33 ` Bedia, Vaibhav
2012-11-03 16:22 ` Kevin Hilman
2012-11-05 4:40 ` Bedia, Vaibhav
2012-11-03 16:31 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-08 20:41 ` Jon Hunter
2012-11-12 22:54 ` Tony Lindgren
2012-11-02 12:32 ` [PATCH 12/15] ARM: OMAP: timer: Add suspend-resume callbacks for clockevent device Vaibhav Bedia
2012-11-03 12:15 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 13:41 ` Kevin Hilman
2012-11-03 14:03 ` Bedia, Vaibhav
2012-11-05 21:20 ` Jon Hunter
2012-11-06 9:38 ` Bedia, Vaibhav
2012-11-06 16:02 ` Jon Hunter
2012-11-03 15:52 ` Santosh Shilimkar
2012-11-04 15:25 ` Bedia, Vaibhav
2012-11-05 14:55 ` Santosh Shilimkar
2012-11-05 21:04 ` Jon Hunter
2012-11-06 7:32 ` Bedia, Vaibhav
2012-11-06 16:00 ` Jon Hunter
2012-11-02 12:32 ` [PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox Vaibhav Bedia
2012-11-03 12:16 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 15:54 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 14:53 ` Santosh Shilimkar
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-05 19:29 ` Kevin Hilman
2012-11-05 21:19 ` Santosh Shilimkar
2012-11-05 21:45 ` Santosh Shilimkar
2012-11-06 5:08 ` Bedia, Vaibhav
2012-11-05 14:58 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 14/15] ARM: OMAP2+: omap2plus_defconfig: Enable Mailbox Vaibhav Bedia
2012-11-03 12:20 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 13:43 ` Kevin Hilman
2012-11-02 12:32 ` [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support Vaibhav Bedia
2012-11-02 13:11 ` Bedia, Vaibhav
2012-11-03 16:57 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 17:40 ` Kevin Hilman
2012-11-05 21:52 ` Santosh Shilimkar
2012-11-06 12:29 ` Bedia, Vaibhav
2012-11-06 12:38 ` Santosh Shilimkar
2012-11-06 13:00 ` Bedia, Vaibhav
2012-11-06 10:40 ` Bedia, Vaibhav
2012-11-07 1:06 ` Kevin Hilman
2012-11-07 13:25 ` Bedia, Vaibhav
2012-11-07 17:15 ` Kevin Hilman
2012-11-08 13:05 ` Bedia, Vaibhav
2012-11-02 22:16 ` [RFC 00/15] Add basic suspend-resume support for AM33XX Daniel Mack
2012-11-03 8:39 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098D889.60909@ti.com \
--to=hvaibhav@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox