From: jon-hunter@ti•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 12/15] ARM: OMAP: timer: Add suspend-resume callbacks for clockevent device
Date: Tue, 6 Nov 2012 10:02:25 -0600 [thread overview]
Message-ID: <50993491.6060606@ti.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EC04897@DBDE01.ent.ti.com>
On 11/06/2012 03:38 AM, Bedia, Vaibhav wrote:
> Hi Jon,
>
> On Tue, Nov 06, 2012 at 02:50:50, Hunter, Jon wrote:
> [...]
>>
>> Why is this? How is the dmtimer TIOCP_CFG register configured on AM33xx?
>> Is it using smart-idle?
>>
>
> Yes, it is set to smart-idle with wakeup capable mode. (this needs a fixup
> since this timer is not wakeup capable) but unfortunately this is not
> sufficient. On AM33xx there's no HW_AUTO mode magic so unless the IPs in
> PER domain are disabled by s/w, PER domain can't transition.
>
>>> The next one is that
>>> the clockevent doesn't generate any further interrupts once the
>>> system resumes. We need to restore the pre-suspend configuration.
>>> I haven't tried but I guess we could have used the save and restore
>>> of timer registers here.
>>
>> It would be interesting to try using an non-wakeup domain timer on
>> OMAP3/4 for clock events and seeing if suspend/resume works.
>>
>> Do you know what the exact problem here is? I understand that the timer
>> context could get lost, but exactly what is not getting restarted by the
>> kernel? For example, the only place we set the interrupt enable is
>> during the clock event init and so if the context is lost, then I could
>> see no more interrupts occurring. So is it enough to just restore the
>> interrupt enable register, do you really need to program the timer again?
>>
>
> Just restoring the interrupt enable register works. But since there's no logic
> retention I think a context save-restore would be better.
Ok, we may need to check the order in which events occur following
resume. The kernel will restart the clock-events and we just need to
make sure we do not restore the context after the clock-events has been
restarted.
Cheers
Jon
next prev parent reply other threads:[~2012-11-06 16:02 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 12:32 [RFC 00/15] Add basic suspend-resume support for AM33XX Vaibhav Bedia
2012-11-02 12:32 ` [PATCH 01/15] ARM: OMAP2+: mailbox: Add an API for flushing the FIFO Vaibhav Bedia
2012-11-02 19:00 ` Tony Lindgren
2012-11-03 8:24 ` Bedia, Vaibhav
2012-11-03 16:03 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 14:59 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 02/15] ARM: OMAP2+: mailbox: Add support for AM33XX Vaibhav Bedia
2012-11-03 0:14 ` Russ Dill
2012-11-03 8:39 ` Bedia, Vaibhav
2012-11-03 13:48 ` Bedia, Vaibhav
2012-11-03 16:10 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 15:00 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 03/15] ARM: OMAP: mailbox: Convert to device_initcall Vaibhav Bedia
2012-11-03 16:12 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX Vaibhav Bedia
2012-11-05 6:58 ` Vaibhav Hiremath
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-06 6:06 ` Hiremath, Vaibhav
2012-11-06 7:19 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 05/15] ARM: OMAP2+: AM33XX: Update WKUP_M3 hwmod entry for reset status Vaibhav Bedia
2012-11-03 16:15 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 6:59 ` Vaibhav Hiremath
2012-11-02 12:32 ` [PATCH 06/15] ARM: OMAP2+: hwmod: Enable OCMCRAM registration in AM33XX Vaibhav Bedia
2012-11-03 16:16 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 7:23 ` Vaibhav Hiremath
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-06 6:07 ` Hiremath, Vaibhav
2012-11-02 12:32 ` [PATCH 07/15] ARM: OMAP2+: hwmod: Update the hwmod data for TPTCs " Vaibhav Bedia
2012-11-05 7:19 ` Vaibhav Hiremath
2012-11-02 12:32 ` [PATCH 08/15] ARM: OMAP2+: hwmod: Fix the omap_hwmod_addr_space for CPGMAC0 Vaibhav Bedia
2012-11-03 16:18 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 9:10 ` Bedia, Vaibhav
2012-11-06 9:29 ` Vaibhav Hiremath
2012-11-06 10:09 ` Bedia, Vaibhav
2012-11-06 13:08 ` Hiremath, Vaibhav
2012-11-06 13:46 ` Bedia, Vaibhav
2012-11-06 13:50 ` Benoit Cousson
2012-11-06 13:56 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 09/15] ARM: OMAP: AM33XX: Remove unnecessary include and use __ASSEMBLER__ macros Vaibhav Bedia
2012-11-03 16:29 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-02 12:32 ` [PATCH 10/15] ARM: OMAP2+: control: Add some AM33XX Control module registers Vaibhav Bedia
2012-11-02 12:32 ` [PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX Vaibhav Bedia
2012-11-03 11:43 ` Kevin Hilman
2012-11-03 12:47 ` Bedia, Vaibhav
2012-11-03 13:04 ` Kevin Hilman
2012-11-03 13:48 ` Bedia, Vaibhav
2012-11-05 18:03 ` Kevin Hilman
2012-11-05 21:59 ` Santosh Shilimkar
2012-11-06 14:38 ` Bedia, Vaibhav
2012-11-08 13:15 ` Bedia, Vaibhav
2012-11-06 14:33 ` Bedia, Vaibhav
2012-11-03 16:22 ` Kevin Hilman
2012-11-05 4:40 ` Bedia, Vaibhav
2012-11-03 16:31 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-08 20:41 ` Jon Hunter
2012-11-12 22:54 ` Tony Lindgren
2012-11-02 12:32 ` [PATCH 12/15] ARM: OMAP: timer: Add suspend-resume callbacks for clockevent device Vaibhav Bedia
2012-11-03 12:15 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 13:41 ` Kevin Hilman
2012-11-03 14:03 ` Bedia, Vaibhav
2012-11-05 21:20 ` Jon Hunter
2012-11-06 9:38 ` Bedia, Vaibhav
2012-11-06 16:02 ` Jon Hunter [this message]
2012-11-03 15:52 ` Santosh Shilimkar
2012-11-04 15:25 ` Bedia, Vaibhav
2012-11-05 14:55 ` Santosh Shilimkar
2012-11-05 21:04 ` Jon Hunter
2012-11-06 7:32 ` Bedia, Vaibhav
2012-11-06 16:00 ` Jon Hunter
2012-11-02 12:32 ` [PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox Vaibhav Bedia
2012-11-03 12:16 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 15:54 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 14:53 ` Santosh Shilimkar
2012-11-05 17:57 ` Bedia, Vaibhav
2012-11-05 19:29 ` Kevin Hilman
2012-11-05 21:19 ` Santosh Shilimkar
2012-11-05 21:45 ` Santosh Shilimkar
2012-11-06 5:08 ` Bedia, Vaibhav
2012-11-05 14:58 ` Santosh Shilimkar
2012-11-02 12:32 ` [PATCH 14/15] ARM: OMAP2+: omap2plus_defconfig: Enable Mailbox Vaibhav Bedia
2012-11-03 12:20 ` Kevin Hilman
2012-11-03 13:17 ` Bedia, Vaibhav
2012-11-03 13:43 ` Kevin Hilman
2012-11-02 12:32 ` [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support Vaibhav Bedia
2012-11-02 13:11 ` Bedia, Vaibhav
2012-11-03 16:57 ` Santosh Shilimkar
2012-11-04 15:26 ` Bedia, Vaibhav
2012-11-05 17:40 ` Kevin Hilman
2012-11-05 21:52 ` Santosh Shilimkar
2012-11-06 12:29 ` Bedia, Vaibhav
2012-11-06 12:38 ` Santosh Shilimkar
2012-11-06 13:00 ` Bedia, Vaibhav
2012-11-06 10:40 ` Bedia, Vaibhav
2012-11-07 1:06 ` Kevin Hilman
2012-11-07 13:25 ` Bedia, Vaibhav
2012-11-07 17:15 ` Kevin Hilman
2012-11-08 13:05 ` Bedia, Vaibhav
2012-11-02 22:16 ` [RFC 00/15] Add basic suspend-resume support for AM33XX Daniel Mack
2012-11-03 8:39 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50993491.6060606@ti.com \
--to=jon-hunter@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox