* [PATCH v3 02/12] ARM: EXYNOS: Add clk_ops for gating clocks of System MMU
@ 2012-11-21 5:03 Cho KyongHo
2012-11-21 15:50 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Cho KyongHo @ 2012-11-21 5:03 UTC (permalink / raw)
To: linux-arm-kernel
Touching some System MMU needs its master devices' clock to be enabled
before. This commit adds clk_ops.set_parent of gating clocks of System
MMU to ensure gating clocks of System MMU's mater devices are enabled
when enabling gating clocks of System MMU.
Change-Id: Icd58b12f599e92692c032516331a444f4703ba6b
Signed-off-by: KyongHo Cho <pullip.cho@samsung•com>
---
arch/arm/mach-exynos/clock-exynos5.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
index 9e815ae..9dfb845 100644
--- a/arch/arm/mach-exynos/clock-exynos5.c
+++ b/arch/arm/mach-exynos/clock-exynos5.c
@@ -613,6 +613,16 @@ static struct clksrc_clk exynos5_clk_aclk_300_gscl = {
.reg_src = { .reg = EXYNOS5_CLKSRC_TOP3, .shift = 10, .size = 1 },
};
+static int exynos5_gate_clk_set_parent(struct clk *clk, struct clk *parent)
+{
+ clk->parent = parent;
+ return 0;
+}
+
+static struct clk_ops exynos5_gate_clk_ops = {
+ .set_parent = exynos5_gate_clk_set_parent
+};
+
static struct clk exynos5_init_clocks_off[] = {
{
.name = "timers",
@@ -854,76 +864,91 @@ static struct clk exynos5_init_clocks_off[] = {
.name = "sysmmu",
.devname = "exynos-sysmmu.0",
.enable = &exynos5_clk_ip_mfc_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 1),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.1",
.enable = &exynos5_clk_ip_mfc_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 2),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.2",
.enable = &exynos5_clk_ip_disp1_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 9)
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.3",
.enable = &exynos5_clk_ip_gen_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 7),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.4",
.enable = &exynos5_clk_ip_gen_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 6)
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.5",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 7),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.6",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 8),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.7",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 9),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.8",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 10),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.9",
.enable = &exynos5_clk_ip_isp0_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (0x3F << 8),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.10",
.enable = &exynos5_clk_ip_isp1_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (0xF << 4),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.11",
.enable = &exynos5_clk_ip_disp1_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 8)
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.12",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 11),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.13",
.enable = &exynos5_clk_ip_gscl_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 12),
}, {
.name = "sysmmu",
.devname = "exynos-sysmmu.14",
.enable = &exynos5_clk_ip_acp_ctrl,
+ .ops = &exynos5_gate_clk_ops,
.ctrlbit = (1 << 7)
}
};
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 02/12] ARM: EXYNOS: Add clk_ops for gating clocks of System MMU
2012-11-21 5:03 [PATCH v3 02/12] ARM: EXYNOS: Add clk_ops for gating clocks of System MMU Cho KyongHo
@ 2012-11-21 15:50 ` Kukjin Kim
2012-11-22 4:51 ` KyongHo Cho
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2012-11-21 15:50 UTC (permalink / raw)
To: linux-arm-kernel
On 11/21/12 14:03, Cho KyongHo wrote:
> Touching some System MMU needs its master devices' clock to be enabled
> before. This commit adds clk_ops.set_parent of gating clocks of System
> MMU to ensure gating clocks of System MMU's mater devices are enabled
> when enabling gating clocks of System MMU.
>
> Change-Id: Icd58b12f599e92692c032516331a444f4703ba6b
Same here, we don't need this :-)
> Signed-off-by: KyongHo Cho<pullip.cho@samsung•com>
> ---
> arch/arm/mach-exynos/clock-exynos5.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
Looks good to me, and I think, this can be applied independently from
this series. Will apply with removing 'Change-Id'.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 02/12] ARM: EXYNOS: Add clk_ops for gating clocks of System MMU
2012-11-21 15:50 ` Kukjin Kim
@ 2012-11-22 4:51 ` KyongHo Cho
0 siblings, 0 replies; 3+ messages in thread
From: KyongHo Cho @ 2012-11-22 4:51 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 22, 2012 at 12:50 AM, Kukjin Kim <kgene.kim@samsung•com> wrote:
> On 11/21/12 14:03, Cho KyongHo wrote:
>>
>> Touching some System MMU needs its master devices' clock to be enabled
>> before. This commit adds clk_ops.set_parent of gating clocks of System
>> MMU to ensure gating clocks of System MMU's mater devices are enabled
>> when enabling gating clocks of System MMU.
>>
>> Change-Id: Icd58b12f599e92692c032516331a444f4703ba6b
>
>
> Same here, we don't need this :-)
>
>
>> Signed-off-by: KyongHo Cho<pullip.cho@samsung•com>
>> ---
>> arch/arm/mach-exynos/clock-exynos5.c | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>
> Looks good to me, and I think, this can be applied independently from this
> series. Will apply with removing 'Change-Id'.
>
Yes. I missed that.
It will be removed.
Thank you.
Cho KyongHo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121122/ab795569/attachment-0001.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-22 4:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 5:03 [PATCH v3 02/12] ARM: EXYNOS: Add clk_ops for gating clocks of System MMU Cho KyongHo
2012-11-21 15:50 ` Kukjin Kim
2012-11-22 4:51 ` KyongHo Cho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox