From: maxime.ripard@free-electrons•com (Maxime Ripard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc
Date: Thu, 20 Dec 2012 11:42:41 +0100 [thread overview]
Message-ID: <50D2EBA1.4050305@free-electrons.com> (raw)
In-Reply-To: <1355942232-26251-1-git-send-email-plagnioj@jcrosoft.com>
Hi,
Le 19/12/2012 19:37, Jean-Christophe PLAGNIOL-VILLARD a ?crit :
> From: Ludovic Desroches <ludovic.desroches@atmel•com>
>
> at91 adc offers the choice between two resolutions: low and high.
> The low and high resolution values depends on adc IP version, as many IP
> properties have been exposed through device tree, these settings have also
> been added to the dt bindings.
>
> Update at the same time the dtsi.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel•com>
> [plagnioj at jcrosoft.com: udpate current adc dt support]
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
> Cc: linux-iio at vger.kernel.org
> Cc: Nicolas Ferre <nicolas.ferre@atmel•com>
> ---
> .../devicetree/bindings/arm/atmel-adc.txt | 11 +++
> arch/arm/boot/dts/at91sam9260.dtsi | 3 +
> arch/arm/boot/dts/at91sam9g45.dtsi | 3 +
> arch/arm/boot/dts/at91sam9x5.dtsi | 3 +
> drivers/iio/adc/at91_adc.c | 74 ++++++++++++++++++--
> 5 files changed, 90 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> index c63097d..fd2d69e 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> @@ -14,9 +14,17 @@ Required properties:
> - atmel,adc-status-register: Offset of the Interrupt Status Register
> - atmel,adc-trigger-register: Offset of the Trigger Register
> - atmel,adc-vref: Reference voltage in millivolts for the conversions
> + - atmel,adc-res: List of resolution in bits supported by the ADC. List size
> + must be two at least.
> + - atmel,adc-res-names: Contains one identifier string for each resolution
> + in atmel,adc-res property. "lowres" and "highres"
> + identifiers are required.
>
> Optional properties:
> - atmel,adc-use-external: Boolean to enable of external triggers
> + - atmel,adc-use-res: String corresponding to an identifier from
> + atmel,adc-res-names property. If not specified, the highest
> + resolution will be used.
I'm wondering, why are you using such a complex dt parsing code, and
bindings, when you only requires a boolean to switch between 8 and 10
bits mode (which seem to be the only thing you support)?
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-12-20 10:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 18:32 [PATCH 0/3] IIO: AT91: add lowres, sleep and sample&hold time missing support Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37 ` [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc Jean-Christophe PLAGNIOL-VILLARD
2012-12-19 18:37 ` [PATCH 2/3] ARM: AT91: IIO: add sleep mode support Jean-Christophe PLAGNIOL-VILLARD
2012-12-20 10:46 ` Maxime Ripard
2012-12-27 12:09 ` Jonathan Cameron
2012-12-27 17:54 ` Maxime Ripard
2012-12-19 18:37 ` [PATCH 3/3] ARM: AT91: IIO: fix missing Sample and Hold time Jean-Christophe PLAGNIOL-VILLARD
2012-12-20 10:55 ` Maxime Ripard
2012-12-20 12:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-21 9:08 ` Maxime Ripard
2012-12-20 10:42 ` Maxime Ripard [this message]
2012-12-20 10:52 ` [PATCH 1/3] ARM: AT91: IIO: add low and high res support for adc ludovic.desroches
2012-12-20 15:51 ` Maxime Ripard
2012-12-20 16:13 ` ludovic.desroches
2012-12-21 9:07 ` Maxime Ripard
2012-12-22 17:21 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-07 9:20 ` Maxime Ripard
2012-12-20 10:40 ` [PATCH 0/3] IIO: AT91: add lowres, sleep and sample&hold time missing support Maxime Ripard
2012-12-20 10:51 ` Nicolas Ferre
2012-12-27 12:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D2EBA1.4050305@free-electrons.com \
--to=maxime.ripard@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox