From: florian@openwrt•org (Florian Fainelli)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Fix phy_init for Marvell network eth driver
Date: Thu, 10 Jan 2013 11:38:07 +0100 [thread overview]
Message-ID: <50EE9A0F.8050008@openwrt.org> (raw)
In-Reply-To: <1357812298-26399-2-git-send-email-konszert@marvell.com>
Le 01/10/13 11:04, Kosta Zertsekel a ?crit :
> At least it fixes DNS323_REV_C1 board case (mach-orion5x/dsn323-setup.c file).
This looks right, but a bit more detail would be welcome, such as:
"The D-Link DNS323_REV_C1 board has a specific PHY device fixup using
the flag MARVELL_PHY_M1118_DNS323_LEDS which is set by the architecture
code in arch/arm/mach-orion5x/dns323-setup.c. This flag is unfortunately
lost during the call to phy_attach() in mv643xx_eth and therefore, the
underlying Marvell PHY driver cannot make use of this flag to fixup the
PHY device LEDs. This patch ensures the phy->dev_flags value is passed
to the phy_attach() function such that the PHY device driver can
actually use it."
>
> Change-Id: I37d64795f79c358f66a211a150cec2263e40e295
> ---
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index 84c1326..7b8c1ac 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -2789,7 +2789,7 @@ static void phy_init(struct mv643xx_eth_private *mp, int speed, int duplex)
>
> phy_reset(mp);
>
> - phy_attach(mp->dev, dev_name(&phy->dev), 0, PHY_INTERFACE_MODE_GMII);
> + phy_attach(mp->dev, dev_name(&phy->dev), phy->dev_flags, PHY_INTERFACE_MODE_GMII);
>
> if (speed == 0) {
> phy->autoneg = AUTONEG_ENABLE;
>
prev parent reply other threads:[~2013-01-10 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 10:04 Fix phy_init for Marvell network eth driver Kosta Zertsekel
2013-01-10 10:04 ` [PATCH] " Kosta Zertsekel
2013-01-10 10:38 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EE9A0F.8050008@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox