* Fix phy_init for Marvell network eth driver @ 2013-01-10 10:04 Kosta Zertsekel 2013-01-10 10:04 ` [PATCH] " Kosta Zertsekel 0 siblings, 1 reply; 3+ messages in thread From: Kosta Zertsekel @ 2013-01-10 10:04 UTC (permalink / raw) To: linux-arm-kernel Hi all, Please review and incorporate (if looks ok) small fix for Marvell mv643xx driver. Thanks, --- KostaZ ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Fix phy_init for Marvell network eth driver 2013-01-10 10:04 Fix phy_init for Marvell network eth driver Kosta Zertsekel @ 2013-01-10 10:04 ` Kosta Zertsekel 2013-01-10 10:38 ` Florian Fainelli 0 siblings, 1 reply; 3+ messages in thread From: Kosta Zertsekel @ 2013-01-10 10:04 UTC (permalink / raw) To: linux-arm-kernel At least it fixes DNS323_REV_C1 board case (mach-orion5x/dsn323-setup.c file). Change-Id: I37d64795f79c358f66a211a150cec2263e40e295 --- drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 84c1326..7b8c1ac 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2789,7 +2789,7 @@ static void phy_init(struct mv643xx_eth_private *mp, int speed, int duplex) phy_reset(mp); - phy_attach(mp->dev, dev_name(&phy->dev), 0, PHY_INTERFACE_MODE_GMII); + phy_attach(mp->dev, dev_name(&phy->dev), phy->dev_flags, PHY_INTERFACE_MODE_GMII); if (speed == 0) { phy->autoneg = AUTONEG_ENABLE; -- 1.8.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Fix phy_init for Marvell network eth driver 2013-01-10 10:04 ` [PATCH] " Kosta Zertsekel @ 2013-01-10 10:38 ` Florian Fainelli 0 siblings, 0 replies; 3+ messages in thread From: Florian Fainelli @ 2013-01-10 10:38 UTC (permalink / raw) To: linux-arm-kernel Le 01/10/13 11:04, Kosta Zertsekel a ?crit : > At least it fixes DNS323_REV_C1 board case (mach-orion5x/dsn323-setup.c file). This looks right, but a bit more detail would be welcome, such as: "The D-Link DNS323_REV_C1 board has a specific PHY device fixup using the flag MARVELL_PHY_M1118_DNS323_LEDS which is set by the architecture code in arch/arm/mach-orion5x/dns323-setup.c. This flag is unfortunately lost during the call to phy_attach() in mv643xx_eth and therefore, the underlying Marvell PHY driver cannot make use of this flag to fixup the PHY device LEDs. This patch ensures the phy->dev_flags value is passed to the phy_attach() function such that the PHY device driver can actually use it." > > Change-Id: I37d64795f79c358f66a211a150cec2263e40e295 > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index 84c1326..7b8c1ac 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -2789,7 +2789,7 @@ static void phy_init(struct mv643xx_eth_private *mp, int speed, int duplex) > > phy_reset(mp); > > - phy_attach(mp->dev, dev_name(&phy->dev), 0, PHY_INTERFACE_MODE_GMII); > + phy_attach(mp->dev, dev_name(&phy->dev), phy->dev_flags, PHY_INTERFACE_MODE_GMII); > > if (speed == 0) { > phy->autoneg = AUTONEG_ENABLE; > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-10 10:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-10 10:04 Fix phy_init for Marvell network eth driver Kosta Zertsekel 2013-01-10 10:04 ` [PATCH] " Kosta Zertsekel 2013-01-10 10:38 ` Florian Fainelli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox