public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
* [PATCH] ARM: mm: Fix missing XN flag for for MT_MEMORY_SO
@ 2013-01-16 14:49 Santosh Shilimkar
  2013-01-16 23:16 ` Russell King - ARM Linux
  0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shilimkar @ 2013-01-16 14:49 UTC (permalink / raw)
  To: linux-arm-kernel

Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support}
added XN flag at section level but missed it at PTE level.

Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.

Cc: Russell King <linux@arm•linux.org.uk>

Reported-by: Richard Woodruff <r-woodruff2@ti•com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
---
 arch/arm/mm/mmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index 9f06102..ce328c7 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -283,7 +283,7 @@ static struct mem_type mem_types[] = {
 	},
 	[MT_MEMORY_SO] = {
 		.prot_pte  = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
-				L_PTE_MT_UNCACHED,
+				L_PTE_MT_UNCACHED | L_PTE_XN,
 		.prot_l1   = PMD_TYPE_TABLE,
 		.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_S |
 				PMD_SECT_UNCACHED | PMD_SECT_XN,
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: mm: Fix missing XN flag for for MT_MEMORY_SO
  2013-01-16 14:49 [PATCH] ARM: mm: Fix missing XN flag for for MT_MEMORY_SO Santosh Shilimkar
@ 2013-01-16 23:16 ` Russell King - ARM Linux
  2013-01-17  6:20   ` Santosh Shilimkar
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2013-01-16 23:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 16, 2013 at 08:19:22PM +0530, Santosh Shilimkar wrote:
> Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support}
> added XN flag at section level but missed it at PTE level.
> 
> Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.
> 
> Cc: Russell King <linux@arm•linux.org.uk>
> 
> Reported-by: Richard Woodruff <r-woodruff2@ti•com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
> ---

Hmm, yes. => patch system please.

>  arch/arm/mm/mmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 9f06102..ce328c7 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -283,7 +283,7 @@ static struct mem_type mem_types[] = {
>  	},
>  	[MT_MEMORY_SO] = {
>  		.prot_pte  = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
> -				L_PTE_MT_UNCACHED,
> +				L_PTE_MT_UNCACHED | L_PTE_XN,
>  		.prot_l1   = PMD_TYPE_TABLE,
>  		.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_S |
>  				PMD_SECT_UNCACHED | PMD_SECT_XN,
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: mm: Fix missing XN flag for for MT_MEMORY_SO
  2013-01-16 23:16 ` Russell King - ARM Linux
@ 2013-01-17  6:20   ` Santosh Shilimkar
  0 siblings, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2013-01-17  6:20 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 17 January 2013 04:46 AM, Russell King - ARM Linux wrote:
> On Wed, Jan 16, 2013 at 08:19:22PM +0530, Santosh Shilimkar wrote:
>> Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support}
>> added XN flag at section level but missed it at PTE level.
>>
>> Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.
>>
>> Cc: Russell King <linux@arm•linux.org.uk>
>>
>> Reported-by: Richard Woodruff <r-woodruff2@ti•com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>> ---
>
> Hmm, yes. => patch system please.
>
7629/1 in patch system.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-17  6:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 14:49 [PATCH] ARM: mm: Fix missing XN flag for for MT_MEMORY_SO Santosh Shilimkar
2013-01-16 23:16 ` Russell King - ARM Linux
2013-01-17  6:20   ` Santosh Shilimkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox