From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type
Date: Tue, 29 Jan 2013 10:10:37 -0700 [thread overview]
Message-ID: <5108028D.5030605@wwwdotorg.org> (raw)
In-Reply-To: <5107D253.5030400@ti.com>
On 01/29/2013 06:44 AM, kishon wrote:
> Hi,
>
> On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote:
>> From: Michael Grzeschik <m.grzeschik@pengutronix•de>
>>
>> This adds two little devicetree helper functions for determining the
>> dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from
>> the devicetree.
>> +/**
>> + * of_get_usbphy_mode - Get phy mode for given device_node
>> + * @np: Pointer to the given device_node
>> + *
>> + * The function gets phy interface string from property 'phy_type',
>> + * and returns the correspondig enum usb_phy_interface
>> + */
>> +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
>> +{
>> + const char *phy_type;
>> + int err, i;
>> +
>> + err = of_property_read_string(np, "phy_type", &phy_type);
>> + if (err < 0)
>> + return USBPHY_INTERFACE_MODE_NA;
>
> Why don't we use a u32 property type for the *phy-type*? IMHO we should
> use string property only when the property should be absolutely
> unambiguous (e.g., compatible property should be string).
Well, this DT property is already defined an in-use, so while a
different decision might (or might not) be made today about the property
name/content, it's already defined and widely in use, so can't really be
changed.
next prev parent reply other threads:[~2013-01-29 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:22 [PATCH, RFC] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-29 11:55 ` Alexander Shishkin
2013-01-30 2:06 ` [PATCH,RFC] " Peter Chen
2013-01-30 14:00 ` Sascha Hauer
2013-01-31 2:05 ` Peter Chen
2013-01-31 10:29 ` Sascha Hauer
2013-02-01 1:11 ` Peter Chen
2013-02-01 6:58 ` Sascha Hauer
2013-02-01 12:21 ` Peter Chen
2013-01-29 13:44 ` kishon
2013-01-29 13:53 ` Wolfram Sang
2013-01-29 14:10 ` kishon
2013-01-29 14:33 ` Felipe Balbi
2013-01-29 14:55 ` Wolfram Sang
2013-01-29 15:05 ` Marc Kleine-Budde
2013-01-30 19:33 ` Matt Sealey
2013-01-30 19:35 ` Matt Sealey
2013-01-29 17:10 ` Stephen Warren [this message]
2013-01-29 20:30 ` Sascha Hauer
2013-01-30 5:51 ` kishon
2013-01-30 10:11 ` Sascha Hauer
2013-01-30 10:31 ` kishon
2013-01-29 17:11 ` [PATCH, RFC] " Stephen Warren
2013-01-29 17:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108028D.5030605@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox