From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH, RFC] usb: add devicetree helpers for determining dr_mode and phy_type
Date: Tue, 29 Jan 2013 10:11:31 -0700 [thread overview]
Message-ID: <510802C3.7090803@wwwdotorg.org> (raw)
In-Reply-To: <1359458548-25071-1-git-send-email-s.hauer@pengutronix.de>
On 01/29/2013 04:22 AM, Sascha Hauer wrote:
> From: Michael Grzeschik <m.grzeschik@pengutronix•de>
>
> This adds two little devicetree helper functions for determining the
> dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from
> the devicetree.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix•de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix•de>
> ---
>
> The properties and their values have been taken from the fsl-mph-dr driver.
> This binding is also documented (though currently not used) for the tegra
> ehci driver (Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt).
> This is a first attempt to parse these bindings at a common place so that
> others can make use of it.
>
> Basically I want to know whether this binding is recommended for new drivers
> since normally the devicetree uses '-' instead of '_', and maybe there are
> other problems with it.
It's certainly typical to use - not _ for freshly defined properties.
However, since this property already exists and is in-use, I don't think
there's any choice but to maintain its current definition.
The code looked fine to me.
next prev parent reply other threads:[~2013-01-29 17:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:22 [PATCH, RFC] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-29 11:55 ` Alexander Shishkin
2013-01-30 2:06 ` [PATCH,RFC] " Peter Chen
2013-01-30 14:00 ` Sascha Hauer
2013-01-31 2:05 ` Peter Chen
2013-01-31 10:29 ` Sascha Hauer
2013-02-01 1:11 ` Peter Chen
2013-02-01 6:58 ` Sascha Hauer
2013-02-01 12:21 ` Peter Chen
2013-01-29 13:44 ` kishon
2013-01-29 13:53 ` Wolfram Sang
2013-01-29 14:10 ` kishon
2013-01-29 14:33 ` Felipe Balbi
2013-01-29 14:55 ` Wolfram Sang
2013-01-29 15:05 ` Marc Kleine-Budde
2013-01-30 19:33 ` Matt Sealey
2013-01-30 19:35 ` Matt Sealey
2013-01-29 17:10 ` Stephen Warren
2013-01-29 20:30 ` Sascha Hauer
2013-01-30 5:51 ` kishon
2013-01-30 10:11 ` Sascha Hauer
2013-01-30 10:31 ` kishon
2013-01-29 17:11 ` Stephen Warren [this message]
2013-01-29 17:16 ` [PATCH, RFC] " Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510802C3.7090803@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox