From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4] ARM: bcm281xx: Add timer driver
Date: Mon, 11 Feb 2013 20:00:17 -0700 [thread overview]
Message-ID: <5119B041.9040007@wwwdotorg.org> (raw)
In-Reply-To: <1360626279-26701-1-git-send-email-csd@broadcom.com>
On 02/11/2013 04:44 PM, Christian Daudt wrote:
> This adds support for the Broadcom timer, used in the following SoCs:
> BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
> +static const struct of_device_id bcm_timer_ids[] __initconst = {
> + {.compatible = "bcm,kona-timer"},
> + {},
> +};
> +
> +static void __init kona_timers_init(void)
> +{
> + struct device_node *node;
> + u32 freq;
> +
> + node = of_find_matching_node(NULL, bcm_timer_ids);
> +
> + if (!node)
> + panic("No timer");
I assume this is for 3.10 now. Can you rework this to remove
bcm_timer_ids[] and that of_find_matching_node() call, and replace it
with e.g.:
CLOCKSOURCE_OF_DECLARE(kona, "bcm,kona-timer", kona_timer_init);
You'd need to change the prototype of kona_timer_init() to accept the DT
node pointer, and pass this through to kona_timers_init().
This would remove the need to have board_bcm.c call the custom
kona_timer_init(); it could use the new standardized clocksource_of_init
instead.
next prev parent reply other threads:[~2013-02-12 3:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 23:44 [PATCH V4] ARM: bcm281xx: Add timer driver Christian Daudt
2013-02-12 3:00 ` Stephen Warren [this message]
2013-02-12 3:25 ` Christian Daudt
2013-02-12 3:39 ` Stephen Warren
2013-02-12 4:44 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5119B041.9040007@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox