From: csd@broadcom•com (Christian Daudt)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4] ARM: bcm281xx: Add timer driver
Date: Mon, 11 Feb 2013 19:25:34 -0800 [thread overview]
Message-ID: <5119B62E.9020901@broadcom.com> (raw)
In-Reply-To: <5119B041.9040007@wwwdotorg.org>
On 13-02-11 07:00 PM, Stephen Warren wrote:
> On 02/11/2013 04:44 PM, Christian Daudt wrote:
>> This adds support for the Broadcom timer, used in the following SoCs:
>> BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
>> diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
>> +static const struct of_device_id bcm_timer_ids[] __initconst = {
>> + {.compatible = "bcm,kona-timer"},
>> + {},
>> +};
>> +
>> +static void __init kona_timers_init(void)
>> +{
>> + struct device_node *node;
>> + u32 freq;
>> +
>> + node = of_find_matching_node(NULL, bcm_timer_ids);
>> +
>> + if (!node)
>> + panic("No timer");
> I assume this is for 3.10 now.
Oh. I missed 3.9 window ? Got busy with other stuff. Oh well, try again.
> Can you rework this to remove
> bcm_timer_ids[] and that of_find_matching_node() call, and replace it
> with e.g.:
>
> CLOCKSOURCE_OF_DECLARE(kona, "bcm,kona-timer", kona_timer_init);
where can I find an example ? I looked throught armsoc/for-next and the
code there has CLOCKSOURCE_OF_DECLARE but it still has
of_find_matching_node calls in the init fns - is it still in the process
of being removed ?
Thanks,
csd
next prev parent reply other threads:[~2013-02-12 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 23:44 [PATCH V4] ARM: bcm281xx: Add timer driver Christian Daudt
2013-02-12 3:00 ` Stephen Warren
2013-02-12 3:25 ` Christian Daudt [this message]
2013-02-12 3:39 ` Stephen Warren
2013-02-12 4:44 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5119B62E.9020901@broadcom.com \
--to=csd@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox