From: wni@nvidia•com (Wei Ni)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver
Date: Wed, 20 Feb 2013 20:29:50 +0800 [thread overview]
Message-ID: <5124C1BE.8030401@nvidia.com> (raw)
In-Reply-To: <20130219235629.GU17833@n2100.arm.linux.org.uk>
On 02/20/2013 07:56 AM, Russell King - ARM Linux wrote:
> On Mon, Feb 18, 2013 at 07:30:29PM +0800, Wei Ni wrote:
>> +static struct tegra_thermal_data * __devinit thermal_tegra_dt_parse_pdata(
>
> __dev* no longer exists.
Ok, I will change it.
>
>> + tdata = devm_kzalloc(&pdev->dev, sizeof(*tdata), GFP_KERNEL);
>> + if (!tdata) {
>> + dev_err(&pdev->dev, "Can't allocate platform data\n");
>> + return NULL;
>> + }
>> + memset(tdata, 0, sizeof(*tdata));
>
> Useless memset. k*z*alloc already zeros the memory before returning.
Yes, I forgot to remove this line.
>
>> +static int tegra30_thermal_probe(struct platform_device *pdev)
>> +{
>> + struct tegra_thermal_data *pdata = pdev->dev.platform_data;
>
> You read pdata here....
>
>> + struct thermal_zone *tz;
>> + struct thermal_sensor *ts;
>> + static struct thermal_cooling_device *cdev;
>> + int ret;
>> +
>> + pdata = thermal_tegra_dt_parse_pdata(pdev);
>
> and immediately overwrite it here.
>
>> + if (!pdata) {
>> + dev_err(&pdev->dev, "Get platform data failed.\n");
>> + return -EINVAL;
>> + }
>> +
>> + /* Create a thermal zone */
>> + tz = create_thermal_zone("tz_tegra", NULL);
>> + if (!tz) {
>> + dev_err(&pdev->dev, "Create thermal_zone failed.\n");
>> + return -EINVAL;
>> + }
>> +
>> + pdata->tz = tz;
>
> This isn't how you deal with driver data. Set driver data against a
> platform device using platform_set_drvdata(pdev, tz).
Yes, I didn't consider it carefully.
As Stephen said, our tegra will only support DT, so I will remove the
platform date.
Thanks.
Wei.
>
>> +static int tegra30_thermal_remove(struct platform_device *pdev)
>> +{
>> + struct tegra_thermal_data *pdata = pdev->dev.platform_data;
>
> and use platform_get_drvdata() here - and don't use pdata->tz.
> struct struct thermal_zone *tz = platform_get_drvdata(pdev);
>
next prev parent reply other threads:[~2013-02-20 12:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 11:30 [RFC PATCH 0/9] Support for tegra30 thermal Wei Ni
2013-02-18 11:30 ` [RFC PATCH 1/9] ARM: dt: t30 cardhu: add dt entry for lm90 Wei Ni
2013-02-19 3:28 ` Alex Courbot
2013-02-19 9:52 ` Wei Ni
2013-02-19 22:48 ` Stephen Warren
2013-02-18 11:30 ` [RFC PATCH 2/9] hwmon: (lm90) split set&show temp as common codes Wei Ni
2013-02-18 22:29 ` Matthew Longnecker
2013-02-19 9:48 ` Wei Ni
2013-02-19 3:31 ` [lm-sensors] " Guenter Roeck
2013-02-19 10:00 ` Wei Ni
2013-02-19 22:56 ` Stephen Warren
2013-02-20 12:31 ` Wei Ni
2013-02-18 11:30 ` [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq Wei Ni
2013-02-19 3:34 ` [lm-sensors] " Guenter Roeck
2013-02-19 10:43 ` Wei Ni
2013-02-19 23:00 ` Stephen Warren
2013-02-20 3:27 ` Alex Courbot
2013-02-20 10:27 ` Wei Ni
2013-02-18 11:30 ` [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Wei Ni
2013-02-19 5:39 ` Alex Courbot
2013-02-19 9:58 ` Wei Ni
2013-02-19 23:02 ` Stephen Warren
2013-02-20 10:29 ` Wei Ni
2013-02-18 11:30 ` [RFC PATCH 5/9] Thermal: Support using dt node to get sensor Wei Ni
2013-02-19 23:12 ` Stephen Warren
2013-02-20 10:36 ` Wei Ni
2013-02-18 11:30 ` [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework Wei Ni
2013-02-19 3:42 ` [lm-sensors] " Guenter Roeck
2013-02-19 10:47 ` Wei Ni
2013-02-19 5:22 ` Alex Courbot
2013-02-19 10:58 ` Wei Ni
2013-02-19 23:18 ` Stephen Warren
2013-02-20 10:40 ` Wei Ni
2013-02-18 11:30 ` [RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver Wei Ni
2013-02-19 23:48 ` Stephen Warren
2013-02-20 12:23 ` Wei Ni
2013-02-19 23:56 ` Russell King - ARM Linux
2013-02-20 12:29 ` Wei Ni [this message]
2013-02-18 11:30 ` [RFC PATCH 8/9] ARM: dt: t30 cardhu: add dt entry for " Wei Ni
2013-02-19 3:42 ` Alex Courbot
2013-02-19 9:56 ` Wei Ni
2013-02-19 23:28 ` Stephen Warren
2013-02-20 11:53 ` Wei Ni
2013-02-20 17:18 ` Stephen Warren
2013-02-18 11:30 ` [RFC PATCH 9/9] ARM: tegra: defconfig: enable thermal framework Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5124C1BE.8030401@nvidia.com \
--to=wni@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox