From: eduardo.valentin@ti•com (Eduardo Valentin)
To: linux-arm-kernel@lists•infradead.org
Subject: [v2, 04/14] thermal: mvebu: Remove unneeded variable initialization
Date: Thu, 11 Apr 2013 12:29:22 -0400 [thread overview]
Message-ID: <5166E4E2.1080606@ti.com> (raw)
In-Reply-To: <1363991114-4225-5-git-send-email-ezequiel.garcia@free-electrons.com>
Rui, Ezequiel,
On 22-03-2013 18:25, Ezequiel Garcia wrote:
> This variable is used only after it's properly initialized,
> so there's no need to set it to NULL in its declaration.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons•com>
>
I am fine with this patch. Though it doesn t hurt to have this
initialization, the code looks cleaner though.
Acked-by: Eduardo Valentin <eduardo.valentin@ti•com>
> ---
> drivers/thermal/mvebu_thermal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/mvebu_thermal.c b/drivers/thermal/mvebu_thermal.c
> index 031f94d..1f502ed 100644
> --- a/drivers/thermal/mvebu_thermal.c
> +++ b/drivers/thermal/mvebu_thermal.c
> @@ -72,7 +72,7 @@ MODULE_DEVICE_TABLE(of, mvebu_thermal_id_table);
>
> static int mvebu_thermal_probe(struct platform_device *pdev)
> {
> - struct thermal_zone_device *thermal = NULL;
> + struct thermal_zone_device *thermal;
> struct mvebu_thermal_priv *priv;
> struct resource *res;
>
>
next prev parent reply other threads:[~2013-04-11 16:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 22:25 [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 01/14] thermal: Rename driver 'kirkwood' -> 'mvebu' Ezequiel Garcia
2013-04-11 16:00 ` [v2,01/14] " Eduardo Valentin
2013-04-11 16:31 ` Ezequiel Garcia
2013-04-11 18:47 ` Eduardo Valentin
2013-04-11 18:57 ` Eduardo Valentin
2013-04-11 19:09 ` Ezequiel Garcia
2013-04-11 16:21 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 02/14] thermal: mvebu: Rename symbols " Ezequiel Garcia
2013-04-11 16:18 ` [v2,02/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 03/14] thermal: mvebu: Move MODULE_DEVICE_TABLE upwards Ezequiel Garcia
2013-04-11 16:25 ` [v2,03/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 04/14] thermal: mvebu: Remove unneeded variable initialization Ezequiel Garcia
2013-04-11 16:29 ` Eduardo Valentin [this message]
2013-04-11 18:54 ` [v2, " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 05/14] thermal: mvebu: Convert to devm_ioremap_resource() Ezequiel Garcia
2013-04-11 16:35 ` [v2,05/14] " Eduardo Valentin
2013-04-11 18:55 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 06/14] thermal: mvebu: Fix license declaration Ezequiel Garcia
2013-04-11 16:40 ` [v2,06/14] " Eduardo Valentin
2013-04-11 18:55 ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 07/14] thermal: mvebu: Rename kirkwood definitions to mvebu Ezequiel Garcia
2013-04-11 16:43 ` [v2,07/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 08/14] thermal: mvebu: Add infrastructure to support more multiple SoC variants Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 09/14] thermal: mvebu: Add support for Armada XP thermal sensor Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 10/14] thermal: mvebu: Add support for Armada 370 " Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 11/14] thermal: mvebu: Add support for Marvell Dove SoC family Ezequiel Garcia
2013-03-23 11:26 ` Sebastian Hesselbarth
2013-03-24 0:16 ` Ezequiel Garcia
2013-03-25 9:34 ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 12/14] ARM: mvebu: Add thermal support to Armada XP device tree Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 13/14] ARM: mvebu: Add thermal support to Armada 370 " Ezequiel Garcia
2013-03-23 14:18 ` Sergei Shtylyov
2013-03-23 14:20 ` Sergei Shtylyov
2013-03-23 14:25 ` Sergei Shtylyov
2013-03-24 0:22 ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 14/14] ARM: configs: Update mvebu, dove and kirkwood defconfigs for thermal Ezequiel Garcia
2013-03-23 18:16 ` [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Jason Cooper
2013-03-23 18:28 ` Sebastian Hesselbarth
2013-03-23 18:31 ` Jason Cooper
2013-03-23 18:38 ` Sebastian Hesselbarth
2013-03-25 9:30 ` Andrew Lunn
2013-03-25 10:45 ` Ezequiel Garcia
2013-03-25 12:23 ` Sebastian Hesselbarth
2013-03-25 12:39 ` Ezequiel Garcia
2013-03-25 13:58 ` Sebastian Hesselbarth
2013-03-25 16:29 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166E4E2.1080606@ti.com \
--to=eduardo.valentin@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox