From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 01/22] [HACK] of: dev_node has struct device pointer
Date: Tue, 16 Jul 2013 16:57:03 -0600 [thread overview]
Message-ID: <51E5CFBF.5080407@wwwdotorg.org> (raw)
In-Reply-To: <1373021097-32420-2-git-send-email-hdoyu@nvidia.com>
On 07/05/2013 04:44 AM, Hiroshi Doyu wrote:
> To prevent of_platform_populate() from trying to populate duplicate
> devices if a device has been already populated.
You need to send drivers/of patches to the DT maintainer and
devicetree-discuss mailing list.
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia•com>
> ---
> Need to take care of early_platform_devices, or alternative solution.
I assume that's a TODO item... Are you planning on fleshing out this
patch to address that issue?
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> +struct device *of_get_device(const struct device_node *node)
> +{
> + struct device *dev;
> + unsigned long flags;
> +
> + raw_spin_lock_irqsave(&devtree_lock, flags);
> + dev = node->dev;
> + raw_spin_unlock_irqrestore(&devtree_lock, flags);
The read (and write in of_set_device()) aren't atomic already? I guess
perhaps they aren't necessarily. It sure seems like some higher-level
locking is needed in of_platform_create_pdata() though, since there's
quite a window there between the get() and set() calls. Or, is there
already some locking in place above that, in which case, I 'm not sure
why there's a need for this level of locking here...
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> + tmp = of_get_device(np);
> + if (tmp) {
> + dev_info(tmp, "Already populated\n");
> + return to_platform_device(tmp);
> + }
Did you check all callers of this function to make sure that they also
don't do any kind of double-processing?
> diff --git a/include/linux/of.h b/include/linux/of.h
> @@ -60,6 +60,9 @@ struct device_node {
> struct kref kref;
> unsigned long _flags;
> void *data;
> +
> + struct device *dev; /* Set only after populated */
> +
> #if defined(CONFIG_SPARC)
Are the extra blank lines needed?
next prev parent reply other threads:[~2013-07-16 22:57 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 10:44 [PATCH v2 00/22] Unified SMMU driver among Tegra SoCs Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 01/22] [HACK] of: dev_node has struct device pointer Hiroshi Doyu
2013-07-16 22:57 ` Stephen Warren [this message]
2013-07-16 23:16 ` Thierry Reding
2013-07-29 10:13 ` Hiroshi Doyu
2013-07-29 13:13 ` Lorenzo Pieralisi
2013-07-05 10:44 ` [PATCH v2 02/22] ARM: tegra: Populate AHB/IOMMU earlier than others Hiroshi Doyu
2013-07-16 23:03 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 03/22] ARM: tegra: Create a DT header defining swgroups ID Hiroshi Doyu
2013-07-16 23:07 ` Stephen Warren
2013-07-29 10:53 ` Hiroshi Doyu
2013-07-29 17:45 ` Stephen Warren
2013-07-30 4:56 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 04/22] ARM: dt: tegra30: iommu: Add "nvidia,swgroup" Hiroshi Doyu
2013-07-16 23:10 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-16 23:14 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia, memory-client" Stephen Warren
2013-07-29 11:06 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-29 17:47 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia, memory-client" Stephen Warren
2013-07-30 5:11 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 06/22] ARM: dt: tegra114: iommu: Fix IOMMU register address Hiroshi Doyu
2013-07-16 23:18 ` Stephen Warren
2013-07-16 23:27 ` Thierry Reding
2013-07-05 10:44 ` [PATCH v2 07/22] ARM: dt: tegra114: iommu: Add "nvidia,swgroups" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 08/22] ARM: dt: tegra114: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 09/22] amba: Move AHB to core_initcall Hiroshi Doyu
2013-07-16 23:20 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 10/22] iommu/tegra: smmu: Move IOMMU " Hiroshi Doyu
2013-07-16 23:21 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 11/22] iommu/tegra: smmu: Add Tegra 114 support Hiroshi Doyu
2013-07-18 20:01 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 12/22] iommu/tegra: smmu: Select ARM_DMA_USE_IOMMU in Kconfig Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 13/22] iommu/tegra: smmu: Create default IOVA maps Hiroshi Doyu
2013-07-18 20:10 ` Stephen Warren
2013-07-29 11:24 ` Hiroshi Doyu
2013-07-29 17:50 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 14/22] iommu/tegra: smmu: Register platform_device to IOMMU dynamically Hiroshi Doyu
2013-07-18 20:17 ` Stephen Warren
2013-07-29 11:27 ` Hiroshi Doyu
2013-07-29 17:54 ` Stephen Warren
2013-07-30 5:18 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 15/22] iommu/tegra: smmu: Calculate ASID register offset by ID Hiroshi Doyu
2013-07-18 20:18 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 16/22] iommu/tegra: smmu: Get "nvidia,swgroup" from DT Hiroshi Doyu
2013-07-18 20:28 ` Stephen Warren
2013-07-29 11:39 ` Hiroshi Doyu
2013-07-29 18:00 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 17/22] iommu/tegra: smmu: Unfied driver for Tegra SoCs Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 18/22] iommu/tegra: smmu: Use dt-bindings MACRO Hiroshi Doyu
2013-07-18 20:30 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 19/22] iommu/tegra: smmu: Workaround PCIe IOMMU'able Hiroshi Doyu
2013-07-18 20:33 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 20/22] iommu/tegra: smmu: Get "nvidia, memory-client" from DT Hiroshi Doyu
2013-07-18 20:40 ` [PATCH v2 20/22] iommu/tegra: smmu: Get "nvidia,memory-client" " Stephen Warren
2013-07-05 10:44 ` [PATCH v2 21/22] iommu/tegra: smmu: Support Multiple ASID Hiroshi Doyu
2013-07-18 20:43 ` Stephen Warren
2013-07-29 10:31 ` Hiroshi Doyu
2013-07-29 17:41 ` Stephen Warren
2013-07-30 5:22 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 22/22] ARM: dma-mapping: Drop GFP_COMP for DMA memory allocations Hiroshi Doyu
2013-07-18 20:45 ` Stephen Warren
2013-07-05 11:03 ` [PATCH v2 00/22] Unified SMMU driver among Tegra SoCs Marc Dietrich
2013-07-05 11:08 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E5CFBF.5080407@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox