From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 13/22] iommu/tegra: smmu: Create default IOVA maps
Date: Mon, 29 Jul 2013 11:50:49 -0600 [thread overview]
Message-ID: <51F6AB79.1000205@wwwdotorg.org> (raw)
In-Reply-To: <20130729.142409.995770519696534476.hdoyu@nvidia.com>
On 07/29/2013 05:24 AM, Hiroshi Doyu wrote:
> Stephen Warren <swarren@wwwdotorg•org> wrote @ Thu, 18 Jul 2013 22:10:29 +0200:
>
>> On 07/05/2013 04:44 AM, Hiroshi Doyu wrote:
>>> Create default IOVA maps at boot-up which can be attached to devices.
>>
>>> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
>>
>>> static int tegra_smmu_probe(struct platform_device *pdev)
>>> {
>>> struct smmu_device *smmu;
>>
>>> @@ -1160,13 +1182,15 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>> if (of_property_read_u32(dev->of_node, "nvidia,#asids", &asids))
>>> return -ENODEV;
>>>
>>> - bytes = sizeof(*smmu) + asids * sizeof(*smmu->as);
>>> + bytes = sizeof(*smmu) + asids * (sizeof(*smmu->as) +
>>> + sizeof(struct dma_iommu_mapping *));
>>> smmu = devm_kzalloc(dev, bytes, GFP_KERNEL);
>>> if (!smmu) {
>>> dev_err(dev, "failed to allocate smmu_device\n");
>>> return -ENOMEM;
>>> }
>>>
>>> + smmu->map = (struct dma_iommu_mapping **)(smmu->as + asids);
>>
>> Shouldn't "+ asids" be "+ asids * sizeof(*smmu->as)" to match the
>> calculation of "bytes" above?
>
> The structure is:
>
> smmu {
> ....
> struct dma_iommu_mapping **map;
> ....
> struct smmu_as as[0];
> };
>
> I think that this is correct, but is the following better?
Oh right, I guess since that's pointer-math, the compiler already
multiplies by the array entry size.
> + smmu->map = (struct dma_iommu_mapping **)&smmu->as[asids];
That would be a bit more obvious.
next prev parent reply other threads:[~2013-07-29 17:50 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 10:44 [PATCH v2 00/22] Unified SMMU driver among Tegra SoCs Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 01/22] [HACK] of: dev_node has struct device pointer Hiroshi Doyu
2013-07-16 22:57 ` Stephen Warren
2013-07-16 23:16 ` Thierry Reding
2013-07-29 10:13 ` Hiroshi Doyu
2013-07-29 13:13 ` Lorenzo Pieralisi
2013-07-05 10:44 ` [PATCH v2 02/22] ARM: tegra: Populate AHB/IOMMU earlier than others Hiroshi Doyu
2013-07-16 23:03 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 03/22] ARM: tegra: Create a DT header defining swgroups ID Hiroshi Doyu
2013-07-16 23:07 ` Stephen Warren
2013-07-29 10:53 ` Hiroshi Doyu
2013-07-29 17:45 ` Stephen Warren
2013-07-30 4:56 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 04/22] ARM: dt: tegra30: iommu: Add "nvidia,swgroup" Hiroshi Doyu
2013-07-16 23:10 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-16 23:14 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia, memory-client" Stephen Warren
2013-07-29 11:06 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-29 17:47 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia, memory-client" Stephen Warren
2013-07-30 5:11 ` [PATCH v2 05/22] ARM: dt: tegra30: iommu: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 06/22] ARM: dt: tegra114: iommu: Fix IOMMU register address Hiroshi Doyu
2013-07-16 23:18 ` Stephen Warren
2013-07-16 23:27 ` Thierry Reding
2013-07-05 10:44 ` [PATCH v2 07/22] ARM: dt: tegra114: iommu: Add "nvidia,swgroups" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 08/22] ARM: dt: tegra114: Add "nvidia,memory-client" Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 09/22] amba: Move AHB to core_initcall Hiroshi Doyu
2013-07-16 23:20 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 10/22] iommu/tegra: smmu: Move IOMMU " Hiroshi Doyu
2013-07-16 23:21 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 11/22] iommu/tegra: smmu: Add Tegra 114 support Hiroshi Doyu
2013-07-18 20:01 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 12/22] iommu/tegra: smmu: Select ARM_DMA_USE_IOMMU in Kconfig Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 13/22] iommu/tegra: smmu: Create default IOVA maps Hiroshi Doyu
2013-07-18 20:10 ` Stephen Warren
2013-07-29 11:24 ` Hiroshi Doyu
2013-07-29 17:50 ` Stephen Warren [this message]
2013-07-05 10:44 ` [PATCH v2 14/22] iommu/tegra: smmu: Register platform_device to IOMMU dynamically Hiroshi Doyu
2013-07-18 20:17 ` Stephen Warren
2013-07-29 11:27 ` Hiroshi Doyu
2013-07-29 17:54 ` Stephen Warren
2013-07-30 5:18 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 15/22] iommu/tegra: smmu: Calculate ASID register offset by ID Hiroshi Doyu
2013-07-18 20:18 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 16/22] iommu/tegra: smmu: Get "nvidia,swgroup" from DT Hiroshi Doyu
2013-07-18 20:28 ` Stephen Warren
2013-07-29 11:39 ` Hiroshi Doyu
2013-07-29 18:00 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 17/22] iommu/tegra: smmu: Unfied driver for Tegra SoCs Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 18/22] iommu/tegra: smmu: Use dt-bindings MACRO Hiroshi Doyu
2013-07-18 20:30 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 19/22] iommu/tegra: smmu: Workaround PCIe IOMMU'able Hiroshi Doyu
2013-07-18 20:33 ` Stephen Warren
2013-07-05 10:44 ` [PATCH v2 20/22] iommu/tegra: smmu: Get "nvidia, memory-client" from DT Hiroshi Doyu
2013-07-18 20:40 ` [PATCH v2 20/22] iommu/tegra: smmu: Get "nvidia,memory-client" " Stephen Warren
2013-07-05 10:44 ` [PATCH v2 21/22] iommu/tegra: smmu: Support Multiple ASID Hiroshi Doyu
2013-07-18 20:43 ` Stephen Warren
2013-07-29 10:31 ` Hiroshi Doyu
2013-07-29 17:41 ` Stephen Warren
2013-07-30 5:22 ` Hiroshi Doyu
2013-07-05 10:44 ` [PATCH v2 22/22] ARM: dma-mapping: Drop GFP_COMP for DMA memory allocations Hiroshi Doyu
2013-07-18 20:45 ` Stephen Warren
2013-07-05 11:03 ` [PATCH v2 00/22] Unified SMMU driver among Tegra SoCs Marc Dietrich
2013-07-05 11:08 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F6AB79.1000205@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox