From: Sudeep.KarkadaNagesha@arm•com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 01/16] of: add support for retrieving cpu node for a given logical cpu index
Date: Mon, 22 Jul 2013 16:07:05 +0100 [thread overview]
Message-ID: <51ED4A99.3030403@arm.com> (raw)
In-Reply-To: <alpine.LFD.2.03.1307221007160.15022@syhkavp.arg>
Hi Nico,
On 22/07/13 15:14, Nicolas Pitre wrote:
> On Mon, 22 Jul 2013, Sudeep KarkadaNagesha wrote:
>
>> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm•com>
>>
>> Currently different drivers requiring to access cpu device node are
>> parsing the device tree themselves. Since the ordering in the DT need
>> not match the logical cpu ordering, the parsing logic needs to consider
>> that. However, this has resulted in lots of code duplication and in some
>> cases even incorrect logic.
>>
>> It's better to consolidate them by adding support for getting cpu
>> device node for a given logical cpu index in DT core library. However
>> logical to physical index mapping can be architecture specific.
>>
>> This patch adds of_get_cpu_node to retrieve a cpu device node for a
>> given logical cpu index. The default matching of the physical id to the
>> logical cpu index can be overridden by architecture specific code.
>>
>> It is recommended to use these helper function only in pre-SMP/early
>> initialisation stages to retrieve CPU device node pointers in logical
>> ordering. Once the cpu devices are registered, it can be retrieved easily
>> from cpu device of_node which avoids unnecessary parsing and matching.
>>
>> Acked-by: Rob Herring <rob.herring@calxeda•com>
>> Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm•com>
>
> Minor nits below. Otherwise...
>
> Acked-by: Nicolas Pitre <nico@linaro•org>
>
Thanks for all the Acks.
>> ---
>> drivers/of/base.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/of.h | 6 +++++
>> 2 files changed, 78 insertions(+)
>>
>> diff --git a/drivers/of/base.c b/drivers/of/base.c
>> index 5c54279..1e690bf 100644
>> --- a/drivers/of/base.c
>> +++ b/drivers/of/base.c
>> @@ -230,6 +230,78 @@ const void *of_get_property(const struct device_node *np, const char *name,
>> }
>> EXPORT_SYMBOL(of_get_property);
>>
>> +/*
>> + * arch_match_cpu_phys_id - Match the given logical CPU and physical id
>> + *
>> + * @cpu: logical index of a cpu
>> + * @phys_id: physical identifier of a cpu
>> + *
>> + * CPU logical to physical index mapping is architecture specific.
>> + * However this __weak function provides a default match of physical
>> + * id to logical cpu index.
>> + *
>> + * Returns true if the physical identifier and the logical index correspond
>> + * to the same cpu, false otherwise.
>> + */
>> +bool __weak arch_match_cpu_phys_id(int cpu, u64 phys_id)
>
> Maybe a prototype declaration for this function should be added to
> include/linux/of.h to avoid mismatch with architecture provided
> versions.
>
Agreed, but include/linux/of.h doesn't seem to be right choice for me as
this function is not really related to OF/DT. I can't choose any better
place either. I don't have a strong opinion on that, just a thought.
Regards,
Sudeep
next prev parent reply other threads:[~2013-07-22 15:07 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:06 [RFC PATCH v2 00/15] DT/core: update cpu device of_node Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 01/15] of: add support for retrieving cpu node for a given logical cpu index Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:30 ` Nicolas Pitre
2013-07-17 14:50 ` Rob Herring
2013-07-17 15:18 ` Sudeep KarkadaNagesha
2013-07-17 14:06 ` [RFC PATCH v2 02/15] driver/core: cpu: initialize of_node in cpu's device struture Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 03/15] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 04/15] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 05/15] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 06/15] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 07/15] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 08/15] cpufreq: cpufreq-cpu0: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 09/15] cpufreq: highbank-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 10/15] cpufreq: spear-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:43 ` Andrew Lunn
2013-07-18 7:53 ` Viresh Kumar
2013-07-18 8:24 ` Sudeep KarkadaNagesha
2013-07-18 10:14 ` Sudeep KarkadaNagesha
2013-07-18 18:30 ` Rob Herring
2013-07-17 14:06 ` [RFC PATCH v2 12/15] cpufreq: arm_big_little: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 13/15] cpufreq: maple-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 14/15] cpufreq: pmac64-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 15/15] cpufreq: pmac32-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-18 7:54 ` [RFC PATCH v2 00/15] DT/core: update cpu device of_node Viresh Kumar
2013-07-22 11:32 ` [PATCH v3 00/16] " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 01/16] of: add support for retrieving cpu node for a given logical cpu index Sudeep KarkadaNagesha
2013-07-22 14:14 ` Nicolas Pitre
2013-07-22 15:07 ` Sudeep KarkadaNagesha [this message]
2013-07-23 10:54 ` Sudeep KarkadaNagesha
2013-08-15 11:32 ` Tomasz Figa
2013-08-15 14:59 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 02/16] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep KarkadaNagesha
2013-07-22 14:14 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 03/16] driver/core: cpu: initialize of_node in cpu's device struture Sudeep KarkadaNagesha
2013-08-15 11:35 ` Tomasz Figa
2013-08-15 15:13 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 04/16] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep KarkadaNagesha
2013-07-22 14:25 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 05/16] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-01 9:54 ` Sudeep KarkadaNagesha
2013-08-01 12:02 ` Jason Cooper
2013-08-05 16:28 ` Sudeep KarkadaNagesha
2013-08-06 8:25 ` Gregory CLEMENT
2013-08-06 9:02 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 06/16] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep KarkadaNagesha
2013-07-22 14:37 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 07/16] of/device: add helper to get cpu device node from logical cpu index Sudeep KarkadaNagesha
2013-07-26 17:01 ` Sudeep KarkadaNagesha
2013-07-26 18:55 ` Rob Herring
2013-07-22 11:32 ` [PATCH v3 08/16] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 09/16] cpufreq: cpufreq-cpu0: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 10/16] cpufreq: highbank-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 11/16] cpufreq: spear-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 12/16] cpufreq: kirkwood-cpufreq: " Sudeep KarkadaNagesha
2013-07-23 9:25 ` Andrew Lunn
2013-07-22 11:32 ` [PATCH v3 13/16] cpufreq: arm_big_little: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 14/16] cpufreq: maple-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 15/16] cpufreq: pmac64-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 16/16] cpufreq: pmac32-cpufreq: " Sudeep KarkadaNagesha
2013-08-01 10:05 ` [PATCH v3 00/16] DT/core: update cpu device of_node Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 1/4] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 2/4] openrisc: " Sudeep KarkadaNagesha
2013-08-16 9:41 ` Sudeep KarkadaNagesha
2013-08-21 5:10 ` Jonas Bonn
2013-08-15 17:09 ` [RFC PATCH 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 4:49 ` Benjamin Herrenschmidt
2013-08-16 8:48 ` Sudeep KarkadaNagesha
2013-08-16 12:32 ` Benjamin Herrenschmidt
2013-08-16 12:44 ` Sudeep KarkadaNagesha
2013-08-16 4:50 ` Benjamin Herrenschmidt
2013-08-16 8:43 ` Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 22:13 ` Benjamin Herrenschmidt
2013-08-19 10:13 ` Sudeep KarkadaNagesha
2013-08-17 10:50 ` Tomasz Figa
2013-08-17 22:09 ` Benjamin Herrenschmidt
2013-08-17 22:22 ` Tomasz Figa
2013-08-19 10:19 ` Mark Rutland
2013-08-19 13:02 ` Rob Herring
2013-08-19 13:56 ` Sudeep KarkadaNagesha
2013-08-22 13:59 ` Mark Rutland
2013-08-22 16:51 ` Sudeep KarkadaNagesha
2013-08-28 19:46 ` Grant Likely
2013-08-29 9:50 ` Lorenzo Pieralisi
2013-08-16 17:39 ` [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 22:14 ` Benjamin Herrenschmidt
2013-08-19 10:21 ` Sudeep KarkadaNagesha
2013-08-19 13:11 ` Rob Herring
2013-08-19 13:24 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 00/19] DT/core: update cpu device of_node Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 01/19] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 02/19] openrisc: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 03/19] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-20 12:27 ` Rafael J. Wysocki
2013-08-20 12:22 ` Sudeep KarkadaNagesha
2013-08-20 21:48 ` Benjamin Herrenschmidt
2013-08-22 6:15 ` Benjamin Herrenschmidt
2013-08-22 13:29 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 04/19] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 05/19] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture Sudeep KarkadaNagesha
2013-08-20 12:28 ` Rafael J. Wysocki
2013-08-20 15:18 ` Greg Kroah-Hartman
2013-08-20 9:30 ` [PATCH v4 07/19] of/device: add helper to get cpu device node from logical cpu index Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 08/19] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 09/19] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 10/19] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 11/19] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 12/19] cpufreq: cpufreq-cpu0: " Sudeep KarkadaNagesha
2013-09-06 13:44 ` Guennadi Liakhovetski
2013-09-09 9:24 ` Sudeep KarkadaNagesha
2013-09-09 14:32 ` Shawn Guo
2013-09-09 15:24 ` Sudeep KarkadaNagesha
2013-09-10 2:44 ` Shawn Guo
2013-09-10 10:56 ` Sudeep KarkadaNagesha
2013-09-10 11:19 ` Shawn Guo
2013-08-20 9:30 ` [PATCH v4 13/19] cpufreq: highbank-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 14/19] cpufreq: spear-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 15/19] cpufreq: kirkwood-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 16/19] cpufreq: arm_big_little: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 17/19] cpufreq: maple-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 18/19] cpufreq: pmac64-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 19/19] cpufreq: pmac32-cpufreq: " Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ED4A99.3030403@arm.com \
--to=sudeep.karkadanagesha@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox