From: Sudeep.KarkadaNagesha@arm•com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 12/19] cpufreq: cpufreq-cpu0: remove device tree parsing for cpu nodes
Date: Mon, 09 Sep 2013 16:24:18 +0100 [thread overview]
Message-ID: <522DE822.3030907@arm.com> (raw)
In-Reply-To: <20130909143253.GD4624@S2101-09.ap.freescale.net>
On 09/09/13 15:32, Shawn Guo wrote:
> Hi Sudeep,
>
> On Mon, Sep 09, 2013 at 10:24:39AM +0100, Sudeep KarkadaNagesha wrote:
>> Hi Shawn,
>>
>> Can you please clarify ? The fix would be as below but I would like to
>> know if setting cpu_dev to get_cpu_device(0) instead of &pdev->dev has
>> any impact on other parts of code using cpu_dev ?
>
> I'm sorry. I should have given it a test on hardware before ACKing the
> changes.
>
> The fix below should not have other impact except the prefix of dev_err
> [info, dbg] message output ('cpufreq-cpu0:' to 'cpu cpu0:'), which
> shouldn't be a problem.
>
Hi Shawn,
Ok. But I am bit suspicious about devm_clk_get(cpu_dev, NULL).
I don't understand completely as how the clock are registered(whether
with dev_id or with connection_id).
A quick grep revealed that i.mx and shmobile is using conection id while
registering. If the clock is registered with connection id and retrieved
with cpu_dev(now dev_id is cpu0 and not cpufreq-cpu0), IIUC that would
break. If we pass pdev->dev for clk_get, it should be fine but again
IIUC it breaks highbank which gets all the information from DT.
So only solution I can think of is to continue to have the code
assigning (&pdev->dev)->of_node with cpu device node which is not clean
and arguable as incorrect since there is no DT node for cpufreq-cpu0.
I don't have a strong opinion though.
Let me know how would you like to fix this.
>>
>> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
>> index cbfffa9..871c336 100644
>> --- a/drivers/cpufreq/cpufreq-cpu0.c
>> +++ b/drivers/cpufreq/cpufreq-cpu0.c
>> @@ -177,7 +177,7 @@ static int cpu0_cpufreq_probe(struct platform_device
>> *pdev)
>> struct device_node *np;
>> int ret;
>>
>> - cpu_dev = &pdev->dev;
>> + cpu_dev = get_cpu_device(0);
>>
>> np = of_node_get(cpu_dev->of_node);
>> if (!np) {
>>
>
> The imx6q-cpufreq driver needs a similar fixing. Please include the
> following changes into your fixing patches. Thanks.
>
Ok no problem I can post the fix based on response for the above question.
Regard,
Sudeep
next prev parent reply other threads:[~2013-09-09 15:24 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:06 [RFC PATCH v2 00/15] DT/core: update cpu device of_node Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 01/15] of: add support for retrieving cpu node for a given logical cpu index Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:30 ` Nicolas Pitre
2013-07-17 14:50 ` Rob Herring
2013-07-17 15:18 ` Sudeep KarkadaNagesha
2013-07-17 14:06 ` [RFC PATCH v2 02/15] driver/core: cpu: initialize of_node in cpu's device struture Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 03/15] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 04/15] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 05/15] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 06/15] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 07/15] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 08/15] cpufreq: cpufreq-cpu0: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 09/15] cpufreq: highbank-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 10/15] cpufreq: spear-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:43 ` Andrew Lunn
2013-07-18 7:53 ` Viresh Kumar
2013-07-18 8:24 ` Sudeep KarkadaNagesha
2013-07-18 10:14 ` Sudeep KarkadaNagesha
2013-07-18 18:30 ` Rob Herring
2013-07-17 14:06 ` [RFC PATCH v2 12/15] cpufreq: arm_big_little: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 13/15] cpufreq: maple-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 14/15] cpufreq: pmac64-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-17 14:06 ` [RFC PATCH v2 15/15] cpufreq: pmac32-cpufreq: " Sudeep.KarkadaNagesha at arm.com
2013-07-18 7:54 ` [RFC PATCH v2 00/15] DT/core: update cpu device of_node Viresh Kumar
2013-07-22 11:32 ` [PATCH v3 00/16] " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 01/16] of: add support for retrieving cpu node for a given logical cpu index Sudeep KarkadaNagesha
2013-07-22 14:14 ` Nicolas Pitre
2013-07-22 15:07 ` Sudeep KarkadaNagesha
2013-07-23 10:54 ` Sudeep KarkadaNagesha
2013-08-15 11:32 ` Tomasz Figa
2013-08-15 14:59 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 02/16] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep KarkadaNagesha
2013-07-22 14:14 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 03/16] driver/core: cpu: initialize of_node in cpu's device struture Sudeep KarkadaNagesha
2013-08-15 11:35 ` Tomasz Figa
2013-08-15 15:13 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 04/16] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep KarkadaNagesha
2013-07-22 14:25 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 05/16] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-01 9:54 ` Sudeep KarkadaNagesha
2013-08-01 12:02 ` Jason Cooper
2013-08-05 16:28 ` Sudeep KarkadaNagesha
2013-08-06 8:25 ` Gregory CLEMENT
2013-08-06 9:02 ` Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 06/16] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep KarkadaNagesha
2013-07-22 14:37 ` Nicolas Pitre
2013-07-22 11:32 ` [PATCH v3 07/16] of/device: add helper to get cpu device node from logical cpu index Sudeep KarkadaNagesha
2013-07-26 17:01 ` Sudeep KarkadaNagesha
2013-07-26 18:55 ` Rob Herring
2013-07-22 11:32 ` [PATCH v3 08/16] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 09/16] cpufreq: cpufreq-cpu0: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 10/16] cpufreq: highbank-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 11/16] cpufreq: spear-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 12/16] cpufreq: kirkwood-cpufreq: " Sudeep KarkadaNagesha
2013-07-23 9:25 ` Andrew Lunn
2013-07-22 11:32 ` [PATCH v3 13/16] cpufreq: arm_big_little: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 14/16] cpufreq: maple-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 15/16] cpufreq: pmac64-cpufreq: " Sudeep KarkadaNagesha
2013-07-22 11:32 ` [PATCH v3 16/16] cpufreq: pmac32-cpufreq: " Sudeep KarkadaNagesha
2013-08-01 10:05 ` [PATCH v3 00/16] DT/core: update cpu device of_node Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 1/4] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 2/4] openrisc: " Sudeep KarkadaNagesha
2013-08-16 9:41 ` Sudeep KarkadaNagesha
2013-08-21 5:10 ` Jonas Bonn
2013-08-15 17:09 ` [RFC PATCH 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 4:49 ` Benjamin Herrenschmidt
2013-08-16 8:48 ` Sudeep KarkadaNagesha
2013-08-16 12:32 ` Benjamin Herrenschmidt
2013-08-16 12:44 ` Sudeep KarkadaNagesha
2013-08-16 4:50 ` Benjamin Herrenschmidt
2013-08-16 8:43 ` Sudeep KarkadaNagesha
2013-08-15 17:09 ` [RFC PATCH 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 0/4] DT: move of_get_cpu_node from PPC to DT core Sudeep KarkadaNagesha
2013-08-16 17:39 ` [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-16 22:13 ` Benjamin Herrenschmidt
2013-08-19 10:13 ` Sudeep KarkadaNagesha
2013-08-17 10:50 ` Tomasz Figa
2013-08-17 22:09 ` Benjamin Herrenschmidt
2013-08-17 22:22 ` Tomasz Figa
2013-08-19 10:19 ` Mark Rutland
2013-08-19 13:02 ` Rob Herring
2013-08-19 13:56 ` Sudeep KarkadaNagesha
2013-08-22 13:59 ` Mark Rutland
2013-08-22 16:51 ` Sudeep KarkadaNagesha
2013-08-28 19:46 ` Grant Likely
2013-08-29 9:50 ` Lorenzo Pieralisi
2013-08-16 17:39 ` [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-16 22:14 ` Benjamin Herrenschmidt
2013-08-19 10:21 ` Sudeep KarkadaNagesha
2013-08-19 13:11 ` Rob Herring
2013-08-19 13:24 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 00/19] DT/core: update cpu device of_node Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 01/19] microblaze: remove undefined of_get_cpu_node declaration Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 02/19] openrisc: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 03/19] powerpc: refactor of_get_cpu_node to support other architectures Sudeep KarkadaNagesha
2013-08-20 12:27 ` Rafael J. Wysocki
2013-08-20 12:22 ` Sudeep KarkadaNagesha
2013-08-20 21:48 ` Benjamin Herrenschmidt
2013-08-22 6:15 ` Benjamin Herrenschmidt
2013-08-22 13:29 ` Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 04/19] of: move of_get_cpu_node implementation to DT core library Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 05/19] ARM: DT/kernel: define ARM specific arch_match_cpu_phys_id Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture Sudeep KarkadaNagesha
2013-08-20 12:28 ` Rafael J. Wysocki
2013-08-20 15:18 ` Greg Kroah-Hartman
2013-08-20 9:30 ` [PATCH v4 07/19] of/device: add helper to get cpu device node from logical cpu index Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 08/19] ARM: topology: remove hwid/MPIDR dependency from cpu_capacity Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 09/19] ARM: mvebu: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 10/19] drivers/bus: arm-cci: avoid parsing DT for cpu device nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 11/19] cpufreq: imx6q-cpufreq: remove device tree parsing for cpu nodes Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 12/19] cpufreq: cpufreq-cpu0: " Sudeep KarkadaNagesha
2013-09-06 13:44 ` Guennadi Liakhovetski
2013-09-09 9:24 ` Sudeep KarkadaNagesha
2013-09-09 14:32 ` Shawn Guo
2013-09-09 15:24 ` Sudeep KarkadaNagesha [this message]
2013-09-10 2:44 ` Shawn Guo
2013-09-10 10:56 ` Sudeep KarkadaNagesha
2013-09-10 11:19 ` Shawn Guo
2013-08-20 9:30 ` [PATCH v4 13/19] cpufreq: highbank-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 14/19] cpufreq: spear-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 15/19] cpufreq: kirkwood-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 16/19] cpufreq: arm_big_little: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 17/19] cpufreq: maple-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 18/19] cpufreq: pmac64-cpufreq: " Sudeep KarkadaNagesha
2013-08-20 9:30 ` [PATCH v4 19/19] cpufreq: pmac32-cpufreq: " Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DE822.3030907@arm.com \
--to=sudeep.karkadanagesha@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox