* [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq()
@ 2013-07-16 0:07 Wei Yongjun
2013-07-16 1:25 ` Wan ZongShun
2013-07-26 7:57 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-07-16 0:07 UTC (permalink / raw)
To: linux-arm-kernel
The IRQ handler nuc900fb_irqhandler() use dev_id as a type of
struct nuc900fb_info *, so we should pass fbi as the device
identity to request_irq().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
---
Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'
---
drivers/video/nuc900fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
index 8c527e5..796e511 100644
--- a/drivers/video/nuc900fb.c
+++ b/drivers/video/nuc900fb.c
@@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
fbinfo->flags = FBINFO_FLAG_DEFAULT;
fbinfo->pseudo_palette = &fbi->pseudo_pal;
- ret = request_irq(irq, nuc900fb_irqhandler, 0,
- pdev->name, fbinfo);
+ ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
if (ret) {
dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
irq, ret);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq()
2013-07-16 0:07 [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq() Wei Yongjun
@ 2013-07-16 1:25 ` Wan ZongShun
2013-07-26 7:57 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Wan ZongShun @ 2013-07-16 1:25 UTC (permalink / raw)
To: linux-arm-kernel
2013/7/16 Wei Yongjun <weiyj.lk@gmail•com>:
> The IRQ handler nuc900fb_irqhandler() use dev_id as a type of
> struct nuc900fb_info *, so we should pass fbi as the device
> identity to request_irq().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
Acked-by: Wan Zongshun <mcuos.com@gmail•com>
Thanks!
Vincent Wan.
> ---
> Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'
> ---
> drivers/video/nuc900fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> index 8c527e5..796e511 100644
> --- a/drivers/video/nuc900fb.c
> +++ b/drivers/video/nuc900fb.c
> @@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
> fbinfo->flags = FBINFO_FLAG_DEFAULT;
> fbinfo->pseudo_palette = &fbi->pseudo_pal;
>
> - ret = request_irq(irq, nuc900fb_irqhandler, 0,
> - pdev->name, fbinfo);
> + ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
> if (ret) {
> dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
> irq, ret);
>
>
--
Wan ZongShun.
www.mcuos.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq()
2013-07-16 0:07 [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq() Wei Yongjun
2013-07-16 1:25 ` Wan ZongShun
@ 2013-07-26 7:57 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 7:57 UTC (permalink / raw)
To: linux-arm-kernel
On 16/07/13 03:07, Wei Yongjun wrote:
> The IRQ handler nuc900fb_irqhandler() use dev_id as a type of
> struct nuc900fb_info *, so we should pass fbi as the device
> identity to request_irq().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
> ---
> Was 'video: nuc900fb: fix to pass correct device identity to free_irq()'
> ---
> drivers/video/nuc900fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> index 8c527e5..796e511 100644
> --- a/drivers/video/nuc900fb.c
> +++ b/drivers/video/nuc900fb.c
> @@ -587,8 +587,7 @@ static int nuc900fb_probe(struct platform_device *pdev)
> fbinfo->flags = FBINFO_FLAG_DEFAULT;
> fbinfo->pseudo_palette = &fbi->pseudo_pal;
>
> - ret = request_irq(irq, nuc900fb_irqhandler, 0,
> - pdev->name, fbinfo);
> + ret = request_irq(irq, nuc900fb_irqhandler, 0, pdev->name, fbi);
> if (ret) {
> dev_err(&pdev->dev, "cannot register irq handler %d -err %d\n",
> irq, ret);
>
Thanks, I've applied this into my 3.11-fixes/fbdev branch.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130726/d6d5ff2b/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-26 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 0:07 [PATCH] video: nuc900fb: fix to pass correct device identity to request_irq() Wei Yongjun
2013-07-16 1:25 ` Wan ZongShun
2013-07-26 7:57 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox