From: afzal@ti•com (Afzal Mohammed)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: dts: AM4372: add few nodes
Date: Mon, 5 Aug 2013 10:38:45 +0530 [thread overview]
Message-ID: <51FF335D.4050803@ti.com> (raw)
In-Reply-To: <51FCEE60.7080809@ti.com>
Hi Muguthan,
On Saturday 03 August 2013 05:19 PM, Mugunthan V N wrote:
> On 8/2/2013 7:16 PM, Afzal Mohammed wrote:
>> + mac: ethernet at 4a100000 {
>> + compatible = "ti,am4372-cpsw","ti,cpsw";
> compatibility "ti,am4372-cpsw" is not needed as driver has only "ti,cpsw"
> compatibility
No, please read device tree documentation [1].
DT is a pure hardware description, it does not depend on driver,
dependency is only vice versa.
>> + reg = <0x4a100000 0x800
>> + 0x4a101200 0x100>;
>> + interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH
>> + GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH
>> + GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH
>> + GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
>> + ti,hwmods = "cpgmac0";
>> + status = "disabled";
>> + };
> There are many other parameters which are missed here.
Reason has been mentioned in the commit message, quoting relevant here
again,
>> For i2c, spi, cpsw & pwm - only the properties that were sure to be
>> correct has been added (main intention is to make hwmod happy and
>> avoid any later modification to here added properties).
I really wanted to avoid a later patch that has a line starting with
minus on DTS.
Since you are working on cpsw support, can you help here with a patch
for other properties.
Regards
Afzal
[1]
http://devicetree.org/Device_Tree_Usage#Understanding_the_compatible_Property
next prev parent reply other threads:[~2013-08-05 5:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 13:46 [PATCH 1/2] ARM: dts: AM4372: cpu(s) node per latest binding Afzal Mohammed
2013-08-02 13:46 ` [PATCH 2/2] ARM: dts: AM4372: add few nodes Afzal Mohammed
2013-08-03 11:49 ` Mugunthan V N
2013-08-05 5:08 ` Afzal Mohammed [this message]
2013-08-05 6:06 ` Mugunthan V N
2013-08-10 14:23 ` Mark Rutland
2013-08-12 6:48 ` Afzal Mohammed
2013-08-16 10:17 ` Benoit Cousson
2013-08-16 23:11 ` Stephen Warren
2013-08-10 14:13 ` [PATCH 1/2] ARM: dts: AM4372: cpu(s) node per latest binding Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF335D.4050803@ti.com \
--to=afzal@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox