From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/3] ARM: bcm281xx: Add GPIO driver
Date: Mon, 19 Aug 2013 16:50:17 -0600 [thread overview]
Message-ID: <5212A129.6080601@wwwdotorg.org> (raw)
In-Reply-To: <1376938761-13657-2-git-send-email-markus.mayer@linaro.org>
On 08/19/2013 12:59 PM, Markus Mayer wrote:
> This patch adds the GPIO driver for the bcm281xx family of chips.
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt b/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt
The simple way to avoid the discussion re: the name of the file might
have been to name it exactly matching the compatible value it documents,
i.e. brcm,kona-gpio.txt. That's what I personally prefer, but it's not
mandatory in any way at all.
> +Broadcom Kona Family GPIO
> +-------------------------
> +
> +This GPIO driver is used in the following Broadcom SoCs:
> + BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> +
> +The GPIO controller only supports edge, not level, triggering of interrupts.
> +
> +- compatible: "brcm,kona-gpio"
Per recent discussions, all the supported compatible values should be
spelled out here, which I assume are:
brcm,kona-gpio
brcm,bcm11130
brcm,bcm11140
brcm,bcm11351
brcm,bcm28145
brcm,bcm28155
Documenting all of them allows drivers to implement quirks/workarounds
based on individual SoCs if ever needed.
Aside from that, the binding seems reasonable, so the binding,
Acked-by: Stephen Warren <swarren@nvidia•com>
next prev parent reply other threads:[~2013-08-19 22:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 18:59 [PATCH v4 0/3] ARM: bcm281xx: GPIO driver Markus Mayer
2013-08-19 18:59 ` [PATCH v4 1/3] ARM: bcm281xx: Add " Markus Mayer
2013-08-19 19:02 ` Florian Fainelli
2013-08-19 19:05 ` Markus Mayer
2013-08-19 19:11 ` Florian Fainelli
2013-08-19 19:23 ` Markus Mayer
2013-08-19 20:54 ` Florian Fainelli
2013-08-19 22:47 ` Tomasz Figa
2013-08-19 22:52 ` Stephen Warren
2013-08-19 22:50 ` Stephen Warren [this message]
2013-08-23 17:34 ` Linus Walleij
2013-08-23 17:58 ` Markus Mayer
2013-08-23 19:30 ` Markus Mayer
2013-08-28 19:50 ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 2/3] ARM: bcm281xx: Enable " Markus Mayer
2013-08-23 17:37 ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 3/3] ARM: bcm281xx: Device Tree bindings for " Markus Mayer
2013-08-19 21:45 ` Tomasz Figa
2013-08-19 22:31 ` Markus Mayer
2013-08-23 17:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212A129.6080601@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox