From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/3] ARM: bcm281xx: Add GPIO driver
Date: Mon, 19 Aug 2013 16:52:33 -0600 [thread overview]
Message-ID: <5212A1B1.2030203@wwwdotorg.org> (raw)
In-Reply-To: <1798078.kJ4bQYzcF9@flatron>
On 08/19/2013 04:47 PM, Tomasz Figa wrote:
> Hi Markus,
>
> Please see my comments inline.
>
> On Monday 19 of August 2013 11:59:19 Markus Mayer wrote:
>> This patch adds the GPIO driver for the bcm281xx family of chips.
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-bcm-kona.txt
>> +- interrupts: The interrupt outputs from the controller. There is one
>> GPIO + interrupt per GPIO bank. The number of GPIO banks is HW
>> configurable.
>
> What do you mean by HW configurable? Does it mean that it depends from
> SoC or you can have different bank configurations on the same SoC?
the wording is a little odd; I was going to comment on it, but thought
it was probably clear enough.
> How does the driver know the layout of GPIO banks? The code suggests that
> the number of interrupts is used as bank count. While this saves you from
> adding any new property or any other way of getting this information, I'm
> not sure if it's completely correct. I'd like to hear others' opinion on
> this, though.
I expect a lookup table with key being the exact compatible value, and
output being the # banks would be a reasonable driver implementation.
Keying off the number of entries in interrupts seems fine too, since it
should work out OK (Tegra does this IIRC).
next prev parent reply other threads:[~2013-08-19 22:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 18:59 [PATCH v4 0/3] ARM: bcm281xx: GPIO driver Markus Mayer
2013-08-19 18:59 ` [PATCH v4 1/3] ARM: bcm281xx: Add " Markus Mayer
2013-08-19 19:02 ` Florian Fainelli
2013-08-19 19:05 ` Markus Mayer
2013-08-19 19:11 ` Florian Fainelli
2013-08-19 19:23 ` Markus Mayer
2013-08-19 20:54 ` Florian Fainelli
2013-08-19 22:47 ` Tomasz Figa
2013-08-19 22:52 ` Stephen Warren [this message]
2013-08-19 22:50 ` Stephen Warren
2013-08-23 17:34 ` Linus Walleij
2013-08-23 17:58 ` Markus Mayer
2013-08-23 19:30 ` Markus Mayer
2013-08-28 19:50 ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 2/3] ARM: bcm281xx: Enable " Markus Mayer
2013-08-23 17:37 ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 3/3] ARM: bcm281xx: Device Tree bindings for " Markus Mayer
2013-08-19 21:45 ` Tomasz Figa
2013-08-19 22:31 ` Markus Mayer
2013-08-23 17:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212A1B1.2030203@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox