From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf
Date: Mon, 26 Aug 2013 10:53:54 -0600 [thread overview]
Message-ID: <521B8822.50304@wwwdotorg.org> (raw)
In-Reply-To: <1377380259-11290-1-git-send-email-b.brezillon@overkiz.com>
On 08/24/2013 03:37 PM, Boris BREZILLON wrote:
> Add support for generic pin configuration to pinctrl-at91 driver.
> diff --git a/Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/atmel,at91-pinctrl.txt
> Required properties for iomux controller:
> -- compatible: "atmel,at91rm9200-pinctrl"
> +- compatible: "atmel,at91rm9200-pinctrl" or "atmel,at91sam9x5-pinctrl".
You seem to also be adding a second chip name to the list here, which is
more than the patch subject/description imply you're doing...
> + Add "generic-pinconf" to the compatible string list to use the generic pin
> + configuration syntax.
"generic-pinconf" is too generic of a compatible value for this binding
to define.
Instead, I think you want to either:
a)
Use compatible="atmel,at91rm9200-pinctrl" for the old binding,
use compatible="atmel,at91rm9200-pinctrl-generic" for the new binding
or:
b)
Define Boolean property atmel,generic-pinconf (perhaps a better name
could be chosen?). If it's not present, parse the node assuming the old
binding. If it is present, parse the node assuming the new binding.
next prev parent reply other threads:[~2013-08-26 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-24 21:32 [RFC PATCH 0/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-24 21:35 ` [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter Boris BREZILLON
2013-08-26 16:50 ` Stephen Warren
2013-08-26 17:01 ` boris brezillon
2013-08-27 3:55 ` Stephen Warren
2013-08-27 6:16 ` boris brezillon
2013-08-27 7:42 ` Nicolas Ferre
2013-08-27 8:28 ` boris brezillon
2013-08-27 21:33 ` Stephen Warren
2013-08-28 13:22 ` Linus Walleij
2013-08-28 13:13 ` Linus Walleij
2013-08-24 21:37 ` [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-26 16:53 ` Stephen Warren [this message]
2013-08-26 17:17 ` boris brezillon
2013-08-27 3:57 ` Stephen Warren
2013-08-27 6:40 ` boris brezillon
2013-08-27 21:35 ` Stephen Warren
2013-08-26 17:53 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 18:45 ` boris brezillon
2013-08-26 19:18 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 19:48 ` boris brezillon
2013-08-27 7:51 ` Nicolas Ferre
2013-08-27 3:54 ` Stephen Warren
2013-08-27 6:04 ` boris brezillon
2013-08-27 21:30 ` Stephen Warren
2013-08-24 21:40 ` [RFC PATCH 3/3] ARM: at91/dt: move sama5 to " Boris BREZILLON
2013-08-28 12:28 ` Linus Walleij
2013-08-28 12:52 ` boris brezillon
2013-08-24 21:43 ` [RFC PATCH 0/3] pinctrl: at91: add support for " boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521B8822.50304@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox