From: b.brezillon@overkiz•com (boris brezillon)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 3/3] ARM: at91/dt: move sama5 to generic pinconf
Date: Wed, 28 Aug 2013 14:52:08 +0200 [thread overview]
Message-ID: <521DF278.3090307@overkiz.com> (raw)
In-Reply-To: <CACRpkdbGWAg19Redc-KB4=dUnNOqCVvFN4H=wAAoki6Y=Zp-wA@mail.gmail.com>
Hello Linus,
On 28/08/2013 14:28, Linus Walleij wrote:
> On Sat, Aug 24, 2013 at 11:40 PM, Boris BREZILLON
> <b.brezillon@overkiz•com> wrote:
>
>> Add generic pinconf definitions and reference appropriate configs in
>> atmel,pins properties.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz•com>
> (...)
>> pinctrl at fffff200 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> - compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "simple-bus";
>> + compatible = "atmel,at91sam9x5-pinctrl", "atmel,at91rm9200-pinctrl", "generic-pinconf", "simple-bus";
> What kind of compatible string is that "generic-pinconf"?
>
> There is no driver that can instantiate against this string but I'm not
> 100% sure about such things. Is there some other driver doing this?
>
> Else I think it'd just be removed.
It did not exist before this patch series.
I thought it would be good idea to add a compatible string to tell if
the pinctrl subnodes support the generic-pinconf binding,
without modifying the current compatible strings:
if compatible string contains the "generic-pinconf" then the pinconf
definitions should be considered generic.
However, after discussing it with Stephen, Jean-Christophe and Nicolas,
I no longer think this is a good idea
(backward compatibility issues).
>
>> + pcfg_none: pcfg_none {
>> + bias-disable;
>> + };
>> +
>> + pcfg_pull_up: pcfg_pull_up {
>> + bias-pull-up;
>> + };
> Nice.
>
>> + pcfg_deglitch: pcfg_deglitch {
>> + input-deglitch = <1>;
>> + };
>> +
>> + pcfg_pull_up_deglitch: pcfg_pull_up_deglitch {
>> + bias-pull-up;
>> + input-deglitch = <1>;
>> + };
> input-deglitch seems like a proposed generic binding but I haven't seen
> these yet?
> (It might be in my violently exploding INBOX though sorry in that case.)
>
> This would need adding to
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> Plus changes to pinctrl core for handling.
This was added in the first patch of this series:
https://lkml.org/lkml/2013/8/24/99
> BTW: this is really moving in the right direction!
>
> Yours,
> Linus Walleij
Thanks.
Best Regards,
Boris
next prev parent reply other threads:[~2013-08-28 12:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-24 21:32 [RFC PATCH 0/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-24 21:35 ` [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter Boris BREZILLON
2013-08-26 16:50 ` Stephen Warren
2013-08-26 17:01 ` boris brezillon
2013-08-27 3:55 ` Stephen Warren
2013-08-27 6:16 ` boris brezillon
2013-08-27 7:42 ` Nicolas Ferre
2013-08-27 8:28 ` boris brezillon
2013-08-27 21:33 ` Stephen Warren
2013-08-28 13:22 ` Linus Walleij
2013-08-28 13:13 ` Linus Walleij
2013-08-24 21:37 ` [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-26 16:53 ` Stephen Warren
2013-08-26 17:17 ` boris brezillon
2013-08-27 3:57 ` Stephen Warren
2013-08-27 6:40 ` boris brezillon
2013-08-27 21:35 ` Stephen Warren
2013-08-26 17:53 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 18:45 ` boris brezillon
2013-08-26 19:18 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 19:48 ` boris brezillon
2013-08-27 7:51 ` Nicolas Ferre
2013-08-27 3:54 ` Stephen Warren
2013-08-27 6:04 ` boris brezillon
2013-08-27 21:30 ` Stephen Warren
2013-08-24 21:40 ` [RFC PATCH 3/3] ARM: at91/dt: move sama5 to " Boris BREZILLON
2013-08-28 12:28 ` Linus Walleij
2013-08-28 12:52 ` boris brezillon [this message]
2013-08-24 21:43 ` [RFC PATCH 0/3] pinctrl: at91: add support for " boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521DF278.3090307@overkiz.com \
--to=b.brezillon@overkiz$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox