From: james.hogan@imgtec•com (James Hogan)
To: linux-arm-kernel@lists•infradead.org
Subject: clk: add support for clock reparent on set_rate
Date: Thu, 29 Aug 2013 12:13:40 +0100 [thread overview]
Message-ID: <521F2CE4.6090107@imgtec.com> (raw)
In-Reply-To: <20130828143652.GA27272@elgon.mountain>
On 28/08/13 15:36, Dan Carpenter wrote:
> Hello James Hogan,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 71472c0c06cf: "clk: add support for clock reparent on
> set_rate" from Jul 29, 2013, leads to the following Smatch complaint:
>
> drivers/clk/clk.c:1117 clk_reparent()
> warn: variable dereferenced before check 'new_parent' (see line 1113)
>
> drivers/clk/clk.c
> 1112 if (new_parent->new_child == clk)
> ^^^^^^^^^^^^^^^^^^^^^
> Patch addes dereference.
>
> 1113 new_parent->new_child = NULL;
> 1114
> 1115 hlist_del(&clk->child_node);
> 1116
> 1117 if (new_parent)
> ^^^^^^^^^^
> Existing check.
>
> 1118 hlist_add_head(&clk->child_node, &new_parent->children);
> 1119 else
Thanks for reporting this Dan - much appreciated. I've submitted a fix.
Cheers
James
parent reply other threads:[~2013-08-29 11:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20130828143652.GA27272@elgon.mountain>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F2CE4.6090107@imgtec.com \
--to=james.hogan@imgtec$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox