* clk: add support for clock reparent on set_rate
[not found] <20130828143652.GA27272@elgon.mountain>
@ 2013-08-29 11:13 ` James Hogan
0 siblings, 0 replies; only message in thread
From: James Hogan @ 2013-08-29 11:13 UTC (permalink / raw)
To: linux-arm-kernel
On 28/08/13 15:36, Dan Carpenter wrote:
> Hello James Hogan,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 71472c0c06cf: "clk: add support for clock reparent on
> set_rate" from Jul 29, 2013, leads to the following Smatch complaint:
>
> drivers/clk/clk.c:1117 clk_reparent()
> warn: variable dereferenced before check 'new_parent' (see line 1113)
>
> drivers/clk/clk.c
> 1112 if (new_parent->new_child == clk)
> ^^^^^^^^^^^^^^^^^^^^^
> Patch addes dereference.
>
> 1113 new_parent->new_child = NULL;
> 1114
> 1115 hlist_del(&clk->child_node);
> 1116
> 1117 if (new_parent)
> ^^^^^^^^^^
> Existing check.
>
> 1118 hlist_add_head(&clk->child_node, &new_parent->children);
> 1119 else
Thanks for reporting this Dan - much appreciated. I've submitted a fix.
Cheers
James
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-08-29 11:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130828143652.GA27272@elgon.mountain>
2013-08-29 11:13 ` clk: add support for clock reparent on set_rate James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox