* [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail @ 2013-10-17 12:45 Krzysztof Kozlowski 2013-10-17 12:48 ` Sylwester Nawrocki 2013-10-17 23:34 ` Mark Brown 0 siblings, 2 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2013-10-17 12:45 UTC (permalink / raw) To: linux-arm-kernel pm_runtime_put() wasn't called if clock rate could not be set up in s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a80376d..0ddaff2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1121,6 +1121,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi) return 0; setup_exit: + pm_runtime_put(&sdd->pdev->dev); /* setup() returns with device de-selected */ disable_cs(sdd, spi); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail 2013-10-17 12:45 [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail Krzysztof Kozlowski @ 2013-10-17 12:48 ` Sylwester Nawrocki 2013-10-17 23:34 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Sylwester Nawrocki @ 2013-10-17 12:48 UTC (permalink / raw) To: linux-arm-kernel On 17/10/13 14:45, Krzysztof Kozlowski wrote: > pm_runtime_put() wasn't called if clock rate could not be set up in > s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung•com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail 2013-10-17 12:45 [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail Krzysztof Kozlowski 2013-10-17 12:48 ` Sylwester Nawrocki @ 2013-10-17 23:34 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Mark Brown @ 2013-10-17 23:34 UTC (permalink / raw) To: linux-arm-kernel On Thu, Oct 17, 2013 at 02:45:41PM +0200, Krzysztof Kozlowski wrote: > pm_runtime_put() wasn't called if clock rate could not be set up in > s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Applied, thanks. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131018/ba324d2d/attachment.sig> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-17 23:34 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-17 12:45 [PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail Krzysztof Kozlowski 2013-10-17 12:48 ` Sylwester Nawrocki 2013-10-17 23:34 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox