From: gerg@uclinux•org (Greg Ungerer)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/8] ARM: imx: add support code for IMX50 based machines
Date: Mon, 28 Oct 2013 16:38:23 +1000 [thread overview]
Message-ID: <526E065F.60206@uclinux.org> (raw)
In-Reply-To: <CAL_JsqJhM=K+vovDALQnjUSXBcuzHev1CUpxEnNqCYfOfGVsWQ@mail.gmail.com>
Hi Rob,
On 24/10/13 21:11, Rob Herring wrote:
> On Fri, Oct 18, 2013 at 1:04 AM, <gerg@uclinux•org> wrote:
>> From: Greg Ungerer <gerg@uclinux•org>
>>
>> Add machine support code for the Freescale IMX50 SoC.
>>
>> It is very similar to the Freescale IMX53, it contains many of the same
>> periperhal hardware modules, at the same address offsets as the IMX53.
>> (Notable exceptions are that the IMX50 contains no CAN bus hardware, less
>> GPIO, no VPU, it does contain an Electrophoretic display controller though).
>>
>> So this support code just uses the IMX53 definitions as they are today.
>> We can add the extra IMX50 definitions in the future when required.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux•org>
>> ---
>> arch/arm/mach-imx/Makefile | 1 +
>> arch/arm/mach-imx/mach-imx50.c | 52 ++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 53 insertions(+)
>> create mode 100644 arch/arm/mach-imx/mach-imx50.c
>>
>> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
>> index 5383c58..9d94f47 100644
>> --- a/arch/arm/mach-imx/Makefile
>> +++ b/arch/arm/mach-imx/Makefile
>> @@ -110,6 +110,7 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD) += mach-cpuimx51sd.o
>> obj-$(CONFIG_MACH_EUKREA_MBIMXSD51_BASEBOARD) += eukrea_mbimxsd51-baseboard.o
>>
>> obj-$(CONFIG_MACH_IMX51_DT) += imx51-dt.o
>> +obj-$(CONFIG_SOC_IMX50) += mach-imx50.o
>> obj-$(CONFIG_SOC_IMX53) += mach-imx53.o
>>
>> obj-$(CONFIG_SOC_VF610) += clk-vf610.o mach-vf610.o
>> diff --git a/arch/arm/mach-imx/mach-imx50.c b/arch/arm/mach-imx/mach-imx50.c
>> new file mode 100644
>> index 0000000..4ac1b91
>> --- /dev/null
>> +++ b/arch/arm/mach-imx/mach-imx50.c
>> @@ -0,0 +1,52 @@
>> +/*
>> + * Copyright 2013 Greg Ungerer <gerg@uclinux•org>
>> + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved.
>> + * Copyright 2011 Linaro Ltd.
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +#include <linux/clk.h>
>> +#include <linux/clkdev.h>
>> +#include <linux/err.h>
>> +#include <linux/io.h>
>> +#include <linux/irq.h>
>> +#include <linux/of_irq.h>
>> +#include <linux/of_platform.h>
>> +#include <asm/mach/arch.h>
>> +#include <asm/mach/time.h>
>> +
>> +#include "common.h"
>> +#include "mx53.h"
>> +
>> +static void __init imx50_dt_init(void)
>> +{
>> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>> +}
>> +
>> +static const char *imx50_dt_board_compat[] __initdata = {
>> + "fsl,imx50",
>> + NULL
>> +};
>> +
>> +static void __init imx50_timer_init(void)
>> +{
>> + mx50_clocks_init_dt();
>> +}
>> +
>> +DT_MACHINE_START(IMX50_DT, "Freescale i.MX50 (Device Tree Support)")
>> + .map_io = mx53_map_io,
>> + .init_early = imx53_init_early,
>> + .init_irq = mx53_init_irq,
>> + .handle_irq = imx53_handle_irq,
>> + .init_time = imx50_timer_init,
>> + .init_machine = imx50_dt_init,
>> + .init_late = imx53_init_late,
>> + .dt_compat = imx50_dt_board_compat,
>> + .restart = mxc_restart,
>> +MACHINE_END
>
> This seems like a lot of duplication. It seems like mx53 and mx50
> could be combined into a single machine_desc. init_time should not be
> needed in 3.13.
Are you suggesting that "fsl,imx50" be added to the board compat list
in mach-imx53.c instead?
Regards
Greg
next prev parent reply other threads:[~2013-10-28 6:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 6:04 [PATCH 0/8] ARM: imx: add IMX50 SoC support gerg at uclinux.org
2013-10-18 6:04 ` [PATCH 1/8] ARM: imx: add debug uart support for IMX50 SoC gerg at uclinux.org
2013-10-18 6:04 ` [PATCH 2/8] ARM: imx: add clocking support code for the " gerg at uclinux.org
2013-10-22 12:27 ` Sascha Hauer
2013-10-23 3:19 ` Greg Ungerer
2013-10-23 9:19 ` Jason Cooper
2013-10-23 12:44 ` Greg Ungerer
2013-10-23 13:42 ` Jason Cooper
2013-10-24 15:11 ` Shawn Guo
2013-10-18 6:04 ` [PATCH 3/8] ARM: imx: add pinctrl " gerg at uclinux.org
2013-10-24 15:16 ` Shawn Guo
2013-10-18 6:04 ` [PATCH 4/8] ARM: imx: add support code for IMX50 based machines gerg at uclinux.org
2013-10-24 11:11 ` Rob Herring
2013-10-28 6:38 ` Greg Ungerer [this message]
2013-10-28 19:57 ` Rob Herring
2013-10-18 6:04 ` [PATCH 5/8] ARM: imx: allow configuration of the IMX50 SoC gerg at uclinux.org
2013-10-24 15:17 ` Shawn Guo
2013-10-18 6:04 ` [PATCH 6/8] ARM: dts: imx: add device tree pin definitions for the IMX50 gerg at uclinux.org
2013-10-18 6:04 ` [PATCH 7/8] ARM: dts: imx: add IMX50 SoC device tree bindings gerg at uclinux.org
2013-10-22 12:35 ` Sascha Hauer
2013-10-22 20:08 ` Matt Sealey
2013-10-22 21:57 ` Sascha Hauer
2013-10-22 22:42 ` Benoît Thébaudeau
2013-10-22 23:06 ` Matt Sealey
2013-10-23 0:17 ` Benoît Thébaudeau
2013-10-23 5:55 ` Greg Ungerer
2013-10-24 21:13 ` Matt Sealey
2013-10-23 5:40 ` Greg Ungerer
2013-10-24 15:26 ` Shawn Guo
2013-10-18 6:04 ` [PATCH 8/8] ARM: dts: imx: add device tree support for Freescale imx50evk board gerg at uclinux.org
2013-10-24 15:29 ` Shawn Guo
2013-10-23 9:14 ` [PATCH 0/8] ARM: imx: add IMX50 SoC support Jason Cooper
2013-10-23 12:39 ` Greg Ungerer
2013-10-24 15:00 ` Shawn Guo
2013-10-25 12:53 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E065F.60206@uclinux.org \
--to=gerg@uclinux$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox