* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 6:36 Alexandre Courbot
2013-11-12 20:04 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Courbot @ 2013-11-12 6:36 UTC (permalink / raw)
To: linux-arm-kernel
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia•com>
---
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 80b801a94677..0fbdadcd96b7 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -92,9 +92,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:03 Stephen Warren
2013-11-12 20:43 ` Olof Johansson
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2013-11-12 20:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Alexandre Courbot <acourbot@nvidia•com>
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia•com>
Signed-off-by: Stephen Warren <swarren@nvidia•com>
---
arm-soc, if you could apply this as a fix for 3.13, that'd be great.
Thanks.
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index ce553d557c31..73368176c6e8 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -90,9 +90,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: tegra: init fuse before setting reset handler
2013-11-12 20:03 Stephen Warren
@ 2013-11-12 20:43 ` Olof Johansson
0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2013-11-12 20:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 12, 2013 at 12:03 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
> From: Alexandre Courbot <acourbot@nvidia•com>
>
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia•com>
> Signed-off-by: Stephen Warren <swarren@nvidia•com>
> ---
> arm-soc, if you could apply this as a fix for 3.13, that'd be great.
> Thanks.
Done!
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-12 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 6:36 [PATCH] ARM: tegra: init fuse before setting reset handler Alexandre Courbot
2013-11-12 20:04 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 20:03 Stephen Warren
2013-11-12 20:43 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox