From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer
Date: Mon, 25 Nov 2013 19:49:01 -0500 [thread overview]
Message-ID: <5293EFFD.9000508@ti.com> (raw)
In-Reply-To: <20131125203956.GI18046@saruman.home>
On Monday 25 November 2013 03:39 PM, Felipe Balbi wrote:
> Hi,
>
[...]
>
>> + kdwc3_dma_mask = dma_get_mask(dev);
>> + dev->dma_mask = &kdwc3_dma_mask;
>> +
>> + error = kdwc3_enable(kdwc);
>
> I would drop this function and just add your clk_prepare() here, then
> move clk_enable()/clk_disable() to ->runtime_resume/->runtime_suspend()
> respectively. Then you could just call pm_runtime_get_sync() when you
> need to access your registers and pm_runtime_put() when you want to drop
> the clock reference.
>
> this will even make PM implementation a lot easier for you going
> forward.
>
Just to make the PM runtime part clear, there are few issues with PM
core clock layer [1], hence drivers is using clock layer. Its trivial
to update the driver though once the issue is sorted out.
Meanwhile driver development continue to be with clock calls.
Regards,
Santosh
[1] https://groups.google.com/forum/#!msg/linux.kernel/w5gFxFsIK-c/jYcnRET_EdAJ
next prev parent reply other threads:[~2013-11-26 0:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 20:16 [PATCH 0/3] Kesytone II USB support WingMan Kwok
2013-11-25 20:16 ` [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-11-25 20:39 ` Felipe Balbi
2013-11-26 0:49 ` Santosh Shilimkar [this message]
2013-11-26 17:16 ` Felipe Balbi
2013-11-26 18:21 ` Santosh Shilimkar
2013-11-27 9:19 ` George Cherian
2013-11-27 17:41 ` Felipe Balbi
2013-11-27 18:32 ` Santosh Shilimkar
2013-11-27 19:39 ` Felipe Balbi
2013-11-25 20:16 ` [PATCH 2/3] ARM: dts: keystone: Add usb devicetree bindings WingMan Kwok
2013-11-25 20:42 ` Felipe Balbi
2013-11-25 21:04 ` Santosh Shilimkar
2013-11-25 21:06 ` Felipe Balbi
2013-11-27 9:59 ` George Cherian
2013-11-27 20:24 ` Santosh Shilimkar
2013-11-25 20:16 ` [PATCH 3/3] ARM: keystone: defconfig: enable USB host mode support WingMan Kwok
2013-11-25 20:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293EFFD.9000508@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox