From: zhouqiao@marvell•com (Qiao Zhou)
To: linux-arm-kernel@lists•infradead.org
Subject: Build warning in drivers/dma/mmp_tdma.c
Date: Mon, 2 Dec 2013 15:34:11 +0800 [thread overview]
Message-ID: <529C37F3.1040205@marvell.com> (raw)
In-Reply-To: <CAMj5Bkjk6v_2Op1oph8GGw2mf8w40c-L3JhBRPNsRewiFxQHpw@mail.gmail.com>
On 12/02/2013 02:42 PM, Zhangfei Gao wrote:
> Thanks Dan
>
> On Fri, Nov 29, 2013 at 6:58 AM, Dan Williams <dan.j.williams@intel•com> wrote:
>
>> I'm also carrying patch to add a missing dependency:
>>
>> commit 1a4ee91dacedde3e82d8ce6eeace7f16884474f9
>> Author: Dan Williams <dan.j.williams@intel•com>
>> Date: Thu Nov 28 12:27:38 2013 -0800
>>
>> dma: mmp_dma depends on CPU_MMP2
>>
>> It calls sram_get_gpool() which is only defined if CONFIG_CPU_MMP2=y
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel•com>
>>
>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> index 446687cc2334..dad83634cb65 100644
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -287,7 +287,7 @@ config DMA_SA11X0
>>
>> config MMP_TDMA
>> bool "MMP Two-Channel DMA support"
>> - depends on ARCH_MMP
>> + depends on ARCH_MMP && CPU_MMP2
>
> Hi, Qiao
>
> Do you have comments?
> Does this work on PXA910?
MMP_TDMA should not depend on CPU_MMP2. PXA910, and other chip set also
use mmp_tdma.
>
> Does sram also use on pxa910?
> arch/arm/mach-mmp/Makefile
> obj-$(CONFIG_CPU_MMP2) += mmp2.o sram.o
yes, PXA910 also uses sram.
>
> Zhangfei
>
--
Best Regards
Qiao
next prev parent reply other threads:[~2013-12-02 7:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 22:58 Build warning in drivers/dma/mmp_tdma.c Dan Williams
2013-11-29 5:31 ` Vinod Koul
2013-12-02 6:42 ` Zhangfei Gao
2013-12-02 7:34 ` Qiao Zhou [this message]
2013-12-02 7:42 ` Zhangfei Gao
[not found] ` <CAPcyv4jfk+JBv7WY_njuYtx8hERZHhoCAij=FOfqxAhLJAHnFA@mail.gmail.com>
2013-12-03 2:13 ` Zhangfei Gao
2013-12-03 2:31 ` Haojian Zhuang
2013-12-03 10:43 ` Qiao Zhou
2013-12-03 11:05 ` Zhangfei Gao
2013-12-04 1:09 ` Qiao Zhou
2013-12-03 21:02 ` Dan Williams
2013-12-04 1:08 ` Qiao Zhou
2013-12-04 1:32 ` Dan Williams
2013-12-04 1:58 ` Qiao Zhou
2013-12-04 2:15 ` Dan Williams
2013-12-04 2:28 ` Qiao Zhou
2013-12-04 2:34 ` Zhangfei Gao
2013-12-04 2:44 ` Qiao Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C37F3.1040205@marvell.com \
--to=zhouqiao@marvell$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox